| 00:41 | <shu> | will review next week or later this week if i decide to work |
| 01:12 | <Michael Ficarra> | I've reviewed it in the past, and I really don't expect to find anything new |
| 01:13 | <Michael Ficarra> | I can do a really quick once-over to make sure there's nothing stray included if you like |
| 01:27 | <bakkot> | Just skim for the syntax/formatting and read my description of the diff, basically |
| 01:31 | <Michael Ficarra> | actually yeah, I see your diff of the rendering, that should be fine |
| 01:32 | <Michael Ficarra> | as long as we've not missed any recently-introduced AOs |
| 01:32 | <Michael Ficarra> | does ecmarkup ensure we don't define an AO without metadata? |
| 01:32 | <Michael Ficarra> | I see my RoundMVResult AO is there |
| 01:35 | <bakkot> | Nope, intentionally so that existing PRs still build |
| 01:35 | <bakkot> | we'll check manually for a while |
| 01:35 | <bakkot> | I'll turn on enforcement at some future point |
| 01:37 | <Michael Ficarra> | k yeah it's not the end of the world if we've missed some |
| 01:37 | <Michael Ficarra> | I'm gonna just stamp it |
| 01:38 | <Michael Ficarra> | ... set a reminder to enable enforcement? |
| 01:38 | <Michael Ficarra> | maybe best to just have a tracking issue |
| 01:39 | <bakkot> | I'll put it in the linting tracking issue |
| 02:06 | <Michael Ficarra> | ljharb: did that do anything? |
| 02:07 | <Michael Ficarra> | I don't have any clue what these numbers mean |
| 02:11 | <ljharb> | now i can post |
| 02:11 | <Michael Ficarra> | lol just needed to add more 9s |
| 02:12 | <ljharb> | ship it |
| 02:13 | <ljharb> | ok so i'll land 545 first, and rebase everything else on top |
| 04:05 | <Michael Ficarra> | ljharb: is 2442 a nontrivial rebase? |
| 04:05 | <ljharb> | yes |
| 04:05 | <Michael Ficarra> | strange |
| 04:05 | <ljharb> | i could probably figure it out but it took more judgement than i wanted |
| 04:05 | <ljharb> | it's like, 2442 changes adjacent to 545 changes, and git not being good at detecting that |
| 05:03 | <ljharb> | does https://github.com/tc39/ecma262/pull/2125 need a post-545 adjustment as well? |
| 05:09 | <Michael Ficarra> | probably not, but it needs further review |
| 05:09 | <Michael Ficarra> | yeah I don't see any new AOs, so it should be ready to go assuming we get approvals |