| 17:18 | <bakkot> | ljharb: just marked https://github.com/tc39/ecma262/pull/2566 as ready; it should go in as the current set of commits imo |
| 17:19 | <bakkot> | I kinda want to bikeshed the names further but we should just land it and maybe bikeshed some future day |
| 19:59 | <shu> | which names you aren't 100% on? |
| 20:01 | <bakkot> | all-but-default, mainly |
| 20:02 | <bakkot> | export * from 'mod' is going to export all but the default name, but the way it's implemented is, it asks the upstream module for all of its names, and then filters out "default", so having the [[ImportName]] be all-but-default is arguably misleading |
| 20:03 | <shu> | ah, i see |
| 20:05 | <shu> | sounds like implementation detail, which makes me feel like all-but-default is accurate enough (certainly more accurate than *). the plumbing of imports and exports is arcana to most people, even those who read the spec regularly |
| 20:07 | <bakkot> | ljharb: jmdyck just pointed out a type issue; I'm going to force-push up a fix in a sec |
| 20:16 | <ljharb> | "all-named"? |
| 20:17 | <bakkot> | The problem isn't that "all but default" is awkward, it's that it's inaccurate as a description of what's being imported |
| 20:35 | <ljharb> | which commit do you want the fixup merged into? |
| 21:00 | <bakkot> | the namespace one |
| 22:56 | <ljharb> | bakkot: there's a merge conflict when i reorder the fixup commit to be right after the namespace commit, and it's not super clear to me what the right resolution is |
| 23:14 | <bakkot> | k, will fix |
| 23:16 | <bakkot> | ljharb: updated |
| 23:18 | <bakkot> | ugh, no, I squash two |
| 23:18 | <bakkot> | one sec |
| 23:19 | <bakkot> | k, actually good now |
| 23:52 | <ljharb> | thanks |