| 00:08 | <shu> | i see some dot-dispatched style calls got !, like ! _env_.InitializeBinding(...), is that enforced by ecmarkup? |
| 00:58 | <bakkot> | nope |
| 00:58 | <bakkot> | we did those by hand :( |
| 00:58 | <shu> | aw :( |
| 00:59 | <bakkot> | at some point I will improve support for internal and concrete methods |
| 00:59 | <bakkot> | this is going to require enforcing that all such method names are globally unique, but, they should be anyway so whatever |
| 01:00 | <shu> | for the purposes of type checking it's probably easier, since they should have the same signatures regardless of overrides |
| 01:05 | <jmdyck> | Depends what you mean by "globally unique": function ER, module ER, and global ER each separately declare/define "GetThisBinding" without 'inheriting' from a common 'abstract method'. But their signatures are all the same, so you could just pretend they do. |
| 01:14 | <shu> | man Intl APIs are kinda wild |
| 01:14 | <shu> | i'm reviewing a bunch of patches to v8. they got option bags that are String or Boolean, the hell |
| 02:00 | <bakkot> |
yeah, or I could define it on the base type and then have "this is not called" assertions for the implementations in the other concrete ER types, which I think we do with some other methods |
| 02:00 | <bakkot> | shu: yeahhhhhh I've been realizing I probably need to pay more attention there |
| 02:01 | <bakkot> | I have absolutely no expertise in the intl parts of intl, but they are also, separately, designing APIs, which is a thing I do have experience with |
| 02:02 | <bakkot> | someday, if we ever finish doing all the major cleanups in 262 and I am not yet burnt out on it, I will try to get ecma402 in line with 262's editorial conventions |
| 18:07 | <Michael Ficarra> | ljharb: in case you didn't see it buried in the comments, https://github.com/tc39/ecma262/pull/2547#discussion_r808600292 |
| 18:08 | <ljharb> | oh thanks, i did miss it |
| 18:13 | <Michael Ficarra> | there's probably 1 or 2 others that I could find if I could load the damn diff.... |
| 18:13 | <ljharb> | https://github.com/tc39/ecma262/pull/2667 |
| 18:13 | <Michael Ficarra> | and I'm not going to scroll through git diff output |
| 18:14 | <ljharb> | after the list and NotifyWaiter PRs land, and yours is rebased, i'll look through it all again and see if i spot anything :-) |
| 18:51 | <ljharb> | want to slap a merge label on 2667? |
| 19:02 | <Michael Ficarra> | ljharb: labeled |
| 23:36 | <bakkot> | shu: did you want to review https://github.com/tc39/ecma262/pull/2305 or are you good relying on michael's/my stamps |