| 20:44 | <Michael Ficarra> | CreateNonEnumerableDataPropertyOrThrow... doesn't throw https://tc39.es/ecma262/#sec-createnonenumerabledatapropertyorthrow |
| 20:45 | <Michael Ficarra> | should we rename it? |
| 20:48 | <shu> | hmm why is step 3 ! there |
| 20:49 | <shu> | i would've expected ? and the callers of CreateNonEnumerableDataPropertyOrThrow to be the ones adding ! |
| 20:49 | <shu> | i originally requested that naming for symmetry with the other CreateDataPropertyOrThrow AO, to be used in the same way |
| 20:59 | <Michael Ficarra> | I would rename it |
| 21:04 | <ljharb> | haven't you brought this up before? |
| 21:04 | <shu> | because there are no throwing users currently? |
| 21:05 | <ljharb> | it was indeed named that for consistency with CreateDataPropertyOrThrow |
| 21:05 | <shu> | like it seems like a generic helper AO to me |
| 21:05 | <shu> | i see no reason to specialize it for all its current users |
| 21:05 | <ljharb> | re the steps, the assertion in step 1 is why step 3 can use ! |
| 21:05 | <ljharb> | we could remove the assertion and change the ! to ?, i suspect, and then the naming would match |
| 21:05 | <shu> | i think the two consistent options are |
| 21:06 | <shu> | do what ljharb just said, or rename it |
| 21:06 | <shu> | the current state is kinda weird |
| 21:07 | <bakkot> | could've sworn we had an issue for this |
| 21:07 | <bakkot> | can't find it though |
| 21:07 | <shu> | we could remove the assertion and change the |
| 21:08 | <bakkot> | ah: https://github.com/tc39/ecma262/pull/2528 |
| 21:08 | <bakkot> | also https://github.com/tc39/ecma262/pull/2759 |
| 23:49 | <Michael Ficarra> | shu: if you have time to do some reviews, we're getting a pretty long list of PRs waiting on your review: https://github.com/tc39/ecma262/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+-reviewed-by%3Asyg+review%3Aapproved+-label%3A%22editor+call%22+draft%3Afalse+-label%3A%22ready+to+merge%22+-label%3A%22pending+stage+4%22+ |
| 23:51 | <shu> | thanks for the ping, will try to make some time |
| 23:51 | <shu> | been swamped for like 2 quarters now |