01:24
<Michael Ficarra>
I'm all caught up on my editor reviews
01:24
<Michael Ficarra>
if you think something else needs my review, let me know
12:55
<jmdyck>
Thanks for reviewing mine. There's also 2886, which is pretty straightforward.
23:38
<bakkot>
shu: regarding the kebab-case lint, are you OK with continuing to have things like ~key+value~ or 100% or whatever?
23:38
<bakkot>
or do you want specifically letters-or-numbers
23:39
<bakkot>
because I personally am fine with ~key+value~ but Michael Ficarra thinks we agreed not to do that
23:40
<shu>
bakkot: i am also fine with ~key+value~
23:41
<shu>
my position is more accurately "lowercase, breaking up words with punctuation instead of capitalization" than kebab-case
23:43
<Michael Ficarra>
shu: what about things like emoji, uncased letters, and logographs?
23:43
<shu>
i don't know why they would come up
23:43
<bakkot>
I don't necessarily want those but I don't care to lint against them
23:44
<Michael Ficarra>
we're trying to figure out whether we consider the rule to be "no uppercase letters or space" or "lowercase letters and numbers split by some punctuator"
23:44
<Michael Ficarra>
the former would permit those things, while the latter would not
23:44
<shu>
i think the former?
23:45
<shu>
like it's a lint, if it filters out most of the cases we'd reject, there's still a human reviewing if we come up against a case we didn't think of that we don't like
23:46
<Michael Ficarra>
sure for our use case, it's not like the input is malicious
23:46
<Michael Ficarra>
but we do have to consider the 402 editors and potentially other users
23:46
<shu>
that more convincingly argues for the former, no?