| 05:15 | <ljharb> | the point of doing that is just to restart all the CI jobs. the reason for needing to do it is the hanging |
| 14:22 | <Michael Ficarra> | This doesn't seem to be a good long-term solution. Is the hanging an npm thing or an us thing? Is anyone else experiencing this? We're just running npm ci, we're not doing anything unusual, right? |
| 15:20 | <ljharb> | it’s not even a short term solution, because it’s not actually fixing anything. I’ll look into it this week |
| 20:23 | <ljharb> | ok, i think i figured it out. basically the fix was to update the sha of my github action workflows - since mine are the only ones pinned to a sha and ecma262 is the only consumer of mine that has them pinned, i totally forgot about the need to update them. please stamp https://github.com/tc39/ecma262/pull/3646 and add the label, and i'll get all the pending PRs landed. |
| 21:34 | <ljharb> | (it's ready to land) |
| 22:04 | <Michael Ficarra> | uuggghhh why do you check in your node_modules? |
| 22:04 | <Michael Ficarra> | this diff is enormous https://github.com/ljharb/actions/compare/dfd9796898850cf07630d1bd4053a7c9a379e90f...7f214d8efdbdcefc96ad9689663ef387a195deec |
| 22:10 | <ljharb> | because all actions have to. i'd much rather not, checking in node_modules is horrendous |
| 22:28 | <ljharb> | merge label, or should i just land it anyways? |
| 22:30 | <Michael Ficarra> | added the label |