18:59 | <Yagiz Nizipli> | Can anybody help me understand this particular test case in URLPattern? https://github.com/whatwg/urlpattern/issues/240 |
19:06 | <Noam Rosenthal> | Yagiz Nizipli: https://urlpattern.spec.whatwg.org/#canonicalize-a-pathname calls https://url.spec.whatwg.org/#url-path-serializer which adds / + segment for every segment |
19:09 | <Noam Rosenthal> | Yagiz Nizipli: anything in particular unclear? |
19:09 | <Yagiz Nizipli> | Canonicalize pathname adds /- if it starts with a leading slash is false. To avoid URL parser to add a / to the beginning https://urlpattern.spec.whatwg.org/#canonicalize-a-pathname |
19:10 | <Yagiz Nizipli> | I think this is an inconsistency between URL parser and the URLPattern spec |
19:10 | <Yagiz Nizipli> | so if I pass /-./my-path to canonicalize_pathname, it will return ./my-path |
19:13 | <Yagiz Nizipli> | sorry. let me clarify: if I pass ./my-path to canonicalize pathname it will call url parser with /- prefix, and later canonicalize will return substr(2) |
19:15 | <Noam Rosenthal> | OK. I was trying to follow the spec by reading but I'm not the expert. |
19:16 | <Yagiz Nizipli> | Yes, I implemented the spec 1 by 1, but this test is failing... https://github.com/ada-url/ada/pull/785 |
22:03 | <Noam Rosenthal> | Yagiz Nizipli: I think you tagged the wrong Anne on the issue |
22:18 | <Yagiz Nizipli> | Yagiz Nizipli: I think you tagged the wrong Anne on the issue |