21:22 | <leobalter> | shu keith_m__ bterlson https://twitter.com/leobalter/status/1282786817482223616 |
21:24 | <shu> | thanks for the heads up! |
21:24 | <keith_m__> | leobalter: 👍🏼. Can you let me know when that lands so I can double check our import script still works? |
21:26 | <leobalter> | when I set main as default I plan to keep the master branch for some time to avoid hazards, but there is no definition yet on how we'll keep master up to date. |
21:27 | <keith_m__> | leobalter: Does changing the default branch mean that cloning tracks the `main` branch instead of `master`? |
21:27 | <leobalter> | nope, and that's the biggest challenge |
21:27 | <keith_m__> | If so I think we should be gtg since AFAIK our import script just clones the repo then cps everything |
21:27 | <keith_m__> | oh |
21:27 | <keith_m__> | ok |
21:27 | <leobalter> | so ideally I'll keep a master branch, and consider how we keep it up to date |
21:27 | <ljharb> | oh, `git clone` always defaults to master? |
21:28 | <leobalter> | no no |
21:28 | <leobalter> | you mean `git clone`? so that's easier |
21:28 | <leobalter> | it gets the default branch, so it switches to `main`, yes |
21:28 | <keith_m__> | Yeah, I think its a fresh clone of the repo |
21:28 | <leobalter> | I read it wrong. |
21:28 | <keith_m__> | not a pull |
21:29 | <leobalter> | fresh clones will have the easiest time |
21:30 | <shu> | chromium pins test262 and all other 3p deps to a specific SHA |
21:30 | <shu> | so i don't think branch names even matter |
21:30 | <shu> | and test262 is one of the manually updated dependencies, so whoever doing the manual updating needs to know, but that's about it |
21:44 | <rkirsling> | keith_m__: oh yeah I forgot that that's how we do it |
21:45 | <rkirsling> | the default mode always fails for me for some reason though |
21:45 | <rkirsling> | so I just point the script at my pre-existing clone |
21:45 | <rkirsling> | one thing that's odd is that the script does mv instead of cp |
21:45 | <rkirsling> | so I need to re-sync my test262 clone after running test262-import lol |
21:45 | <rkirsling> | but that's an unrelated matter |
21:46 | <leobalter> | rkirsling: I believe the mv was set for other purposes |
21:48 | <keith_m__> | rkirsling: You could change it to ditto so it only works on Mac :P (maybe ditto works on linux I just never heard of it...) |
21:49 | <rkirsling> | I mean tbf I only ever deal with test262-{import, runner} on my Mac but it seems bad to lean into that assumption :p |