05:00 | <MylesBorins> | hey all... I accidentally just pushed something really stupid to tc39/ecma262 master |
05:00 | <MylesBorins> | as I'm an admin I temporarily removed branch protection so I could force push and remove the offending commits |
05:00 | <MylesBorins> | I've re-enabled branch protection but may have not enabled all of the correct protections so someone may want to take a look at it |
05:00 | <MylesBorins> | I'm emailing the chair group as well to make sure folks are aware of thins |
05:00 | <MylesBorins> | extremely sorry :S |
05:07 | <ljharb> | MylesBorins: you only needed to uncheck "include administrators", for future reference, you don't have to delete all the settings |
05:07 | <MylesBorins> | GitHub was 404'ing when I tried to edit the rule |
05:07 | <ljharb> | ouch |
05:08 | <MylesBorins> | yeah... and I didn't want to leave those commits there |
05:10 | <Bakkot> | huh, yeah, it worked the first time I clicked "edit" on the rule but now it's 500'ing |
05:10 | <Bakkot> | fun! |
05:10 | <ljharb> | i'll get them set back up |
05:11 | <ljharb> | lol ok well i think i set them up right, but the "edit" page is 500ing so i can't verify |
05:11 | <ljharb> | perhaps someone who works at github could look into that :-p |
05:12 | <Bakkot> | anyway the branch itself looks to be in a reasonable state, which is the most important part |
05:12 | <ljharb> | right, it's the same sha i expect from 3 hours ago |
05:12 | <MylesBorins> | yeah I knew the exact two commits I pushed so it was p easy to rollback |
05:12 | <MylesBorins> | I also have a "git mcfly" alias for just such an occasion |
05:13 | <MylesBorins> | https://github.com/MylesBorins/dot-files/blob/main/.gitconfig#L30 |
05:13 | <Bakkot> | tempted to just repeatedly load the 500'ing page in the hopes of causing enough log messages that someone looks at it |
05:14 | <ljharb> | i wonder how many 500s it takes to trigger pagerduty |
05:17 | <Bakkot> | MylesBorins your dotfile lacks an alias for "git push origin $CURRENT_BRANCH_NAME" |
05:17 | <MylesBorins> | https://github.com/tc39/ecma262/issues/2269 |
05:17 | <Bakkot> | can I recommend `po = "!f() { git push -u origin $(git rev-parse --abbrev-ref HEAD); }; f"` |
05:18 | <MylesBorins> | oh I was on the right branch name |
05:18 | <MylesBorins> | I pushed the wrong remote |
05:18 | <MylesBorins> | should have removed the upstream remote the second I was up to tomfoolery |
05:18 | <MylesBorins> | that's on me |
05:19 | <MylesBorins> | ok gonna go chill out, thanks for being understanding about it :D |
05:19 | <Bakkot> | all is well |
05:19 | <Bakkot> | except github, github is broken |