| 00:38 | <jsbell> | wanderview: I'm probably mucking up the process, but hopefully the feedback so far is useful |
| 06:43 | <MikeSmith> | can anybody remind where there github issue tracker for issues in github itself is |
| 06:53 | <BigPants> | I don't think they have a public tracker, ironically enough |
| 07:11 | <MikeSmith> | BigPants: ok, yeah I had thought I just must not be looking in the right place |
| 08:32 | <Domenic> | MikeSmith: botie disappeared? |
| 08:53 | <MikeSmith> | Domenic: gets wedged sometimes and I need to restart it; will do that now |
| 08:56 | <MikeSmith> | botie, CSS? |
| 08:56 | <botie> | mikesmith: i don't know |
| 09:18 | <Domenic> | botie: inform annevk my jsdom co-contributor seems to have implemented the WHATWG URL spec: https://github.com/jsdom/whatwg-url/blob/master/lib/url.js |
| 09:18 | <botie> | will do |
| 09:18 | <Domenic> | botie: you are inhumanly fast |
| 09:18 | <botie> | OK, Domenic. |
| 10:37 | <botie> | annevk, at 2015-04-29 09:18 UTC, Domenic said: my jsdom co-contributor seems to have implemented the WHATWG URL spec: https://github.com/jsdom/whatwg-url/blob/master/lib/url.js |
| 10:45 | <annevk_> | Domenic: ooh shit, hmm, I wonder if he's interested in implementing a variant... |
| 10:53 | <Domenic> | annevk: probably, the enthusiasm is boundless... and we're going to need to modify it to make file:// URLs on windows work anyway. |
| 10:53 | <Domenic> | (file:// URLs are pretty crucial for jsdom) |
| 10:53 | <annevk> | yeah we need to get them fixed |
| 10:54 | <annevk> | one approach that was suggested to me is define both Unix and Windows with a switch of sorts |
| 10:54 | <annevk> | but it seems so shitty that default depends on a global variable |
| 10:55 | <Domenic> | Yeah I mean my intuition would be that browsers are unlikely to go to the trouble of fixing them ever, so just specify something good and hopefully that will serve the rest of the ecosystem (io.js etc.) |
| 11:05 | <annevk> | Browsers will implement if it improves interop for them |
| 11:05 | <annevk> | Not if it's worse |
| 11:05 | <annevk> | The current spec has some known flaws so is not strictly better than what they have today |
| 11:06 | <Domenic> | I am somewhat doubtful they will care about interop for file: though, so even if it were strictly better, in that case they might just leave the code as-is. |
| 11:46 | <SteveF_> | annevk: hi, any pointers to documentation on why styling of native controls is so probelematic? |
| 12:34 | <philipj> | annevk: I see you've converted DOM but not all your specs to Bikeshed. Do you enjoy using Bikeshed, would you recommend it for new specs? |
| 12:55 | <annevk> | SteveF_: someone at Google did research at some point, but I forgot where it went, but probably requires starting from scratch to some extent... |
| 12:55 | <annevk> | philipj: since it's maintained, yeah |
| 12:56 | <annevk> | philipj: and anything that's broken is fixed quite soonish |
| 12:56 | <annevk> | SteveF_: I think a large part of it is simply missing a solid specification and tests |
| 12:56 | <philipj> | annevk: good, I'm happy you don't regret switching then :) |
| 12:56 | <annevk> | SteveF_: e.g. what the effect of properties needs to be, how appearance behaves, etc. |
| 12:57 | <annevk> | philipj: there's a certain amount of magic, but Anolis has that too and I think I just need to get used to it |
| 13:16 | <MikeSmith> | can somebody remind me the family name of Justin from Polymer who was at the Web Components f2f meeting last week |
| 13:19 | <MikeSmith> | annevk: I'm not sure but I think SteveF_ might have been just wondering for now if there's even a short high-level explanation somewhere of why it's so hard; stuff like, e.g., "Some UAs display replaced content using native platform widgets/controls that aren't themselves styleable." |
| 13:38 | <MikeSmith> | has anybody here ever used gitlab for code review? and if so, how does it compare to other tools you've used (e.g., whatever tools you might have used for browser-project code review, or to Critic [for those of us who have used that]) |
| 14:22 | <wanderview> | jgraham: should I be getting email from critic for reviews? |
| 14:24 | <jgraham> | wanderview: Yes, if you added your email address (or made it public in GitHub) |
| 14:25 | <wanderview> | jgraham: once something is "accepted" I close the review? |
| 14:25 | <wanderview> | jgraham: does it auto-merge the PR, then? |
| 14:26 | <jgraham> | wanderview: Merging in GH will close the review, but not the other way around |
| 14:27 | <wanderview> | jgraham: and you prefer not squashing commits, right? |
| 14:27 | <jgraham> | wanderview: I prefer squashing commits once they have review, but I recognise that most people are too lazy in the face of a big green button that does the wrong thing |
| 14:28 | <wanderview> | jgraham: well, I'm addressing jsbell's review feedback... but he marked accepted... should I just amend the commit then? |
| 14:28 | <jgraham> | wanderview: So he didn't mark accepted |
| 14:29 | <wanderview> | jgraham: this is the review I'm looking at: https://critic.hoppipolla.co.uk/r/4840 |
| 14:29 | <wanderview> | there is a "note" about changing assert_object_equals to assert_equals |
| 14:29 | <jgraham> | "Accepted" is computed from the combination 100% reviewed and no opene issues |
| 14:29 | <jgraham> | A "note" is not an issue |
| 14:29 | <jgraham> | So the review is technically accepted |
| 14:29 | <wanderview> | jgraham: ok... I'm addressing his "note" then :-) |
| 14:30 | <jgraham> | Right, so push your fixup as a new commit |
| 14:30 | <jgraham> | I will review that commit |
| 14:30 | <wanderview> | ok |
| 14:30 | <jgraham> | Then you can either squash and push again, or just merge |
| 14:30 | <wanderview> | jgraham: do I have permissions to merge? |
| 14:31 | <jgraham> | wanderview: Oh, possibly not |
| 14:31 | <wanderview> | I fixed my email, so now I'm getting updates |
| 14:31 | wanderview | adds a new mail filter |
| 14:32 | <jgraham> | wanderview: Want to squash, or want me to just merge? |
| 14:33 | <wanderview> | jgraham: please just merge if you don't mind... I have a meeting coming up, so not a lot of time at the moment |
| 14:33 | <jgraham> | wanderview: Done, and thanks! |
| 14:38 | <wanderview> | jgraham: do you want to give me perms to merge the remaining PRs? I think I understand the process now |
| 14:41 | <wanderview> | jgraham: or, these two are ready for merge as well: https://critic.hoppipolla.co.uk/r/4835 and https://critic.hoppipolla.co.uk/r/4822 |
| 14:47 | <jgraham> | wanderview: I merged them. I din't think I can change who can merge |
| 14:48 | <wanderview> | ok |
| 14:49 | <wanderview> | jgraham: any advice on filtering critic emails in gmail? I can filter the ones from the critic address pretty easily, but the ones it sends from my own address seem harder |
| 14:50 | <TabAtkins> | SteveF_: I started a document at http://dev.w3.org/csswg/css-forms/#examples about form styling. Want to collect more examples before I start working actively. |
| 14:50 | <wanderview> | jgraham: nm... I found the ignoreOwnChanges config |
| 14:50 | <TabAtkins> | annevk: I'd be interested in hearing about what you find "magic" in a bad way. |
| 14:51 | <SteveF_> | TabAtkins: cool thanks for the pointer |
| 14:52 | <jgraham> | wanderview: It also adds headers, but apparently gmail doesn't believe in things like headers |
| 14:52 | <wanderview> | jgraham: I also fixed the style nit in this one... so should be mergeable after that is approved: https://critic.hoppipolla.co.uk/r/4823 |
| 14:53 | <jgraham> | wanderview: Merged |
| 14:53 | <wanderview> | thanks! |
| 15:02 | <annevk> | MikeSmith: I don't think there is that either... |
| 15:02 | <annevk> | MikeSmith: all I know that is written down is that it's out of scope of CSS... |
| 15:03 | <annevk> | TabAtkins: I should probably get more familiar first |
| 15:03 | <annevk> | MikeSmith: Justin Fagnani? |
| 16:45 | <MikeSmith> | annevk: yeah must be Justin Fagnani I guess |
| 16:45 | <MikeSmith> | thanks |
| 17:44 | <wanderview> | JakeA: Domenic: does the current plan for cancellable promise for fetch match this at all? https://github.com/petkaantonov/bluebird/blob/master/API.md#cancellation |
| 17:44 | <wanderview> | just curious |
| 17:45 | <Domenic> | wanderview: my understanding of Bluebird aligns with the current plan being in line with Bluebird 3.x (i.e. Bluebird vNext), learning the lessons of Bluebird 2.x. |
| 17:47 | <wanderview> | Domenic: the cancel interfaces seem pretty similar in the docs of the 3.0 branch |
| 17:48 | <Domenic> | wanderview: https://github.com/petkaantonov/bluebird/issues/415 |
| 17:49 | <wanderview> | thanks |
| 18:51 | <Ms2ger> | jsbell, r? https://critic.hoppipolla.co.uk/r/4818 |
| 18:59 | <jsbell> | Ms2ger: take a peek at https://codereview.chromium.org/1071283004 |
| 19:00 | <jsbell> | Ms2ger: We should check \u000B \u2028 and \u2029 too |
| 19:01 | <Ms2ger> | Want me to add those? |
| 19:01 | <jsbell> | Ms2ger: please! |
| 19:01 | Ms2ger | is no longer used to NUL being special |
| 19:02 | <jsbell> | Ms2ger: heh |
| 19:04 | <Ms2ger> | Oh, you didn't say 0000, you said 000B |
| 19:04 | <Ms2ger> | Eh |
| 19:04 | Ms2ger | adds 0000 too |
| 19:05 | <jsbell> | sgtm |
| 19:06 | <jsbell> | Yep, "vertical tab" might technically be ASCII whitespace, but isn't in the spec's list. |
| 19:08 | Ms2ger | puts the other thing on his todo list |
| 19:08 | <Ms2ger> | jsbell, wanna r+? :) |
| 19:09 | wanderview | ponders "vertical tab"... |
| 19:10 | <jsbell> | Ms2ger: in critic is there a "show me the whole patch" not just individual commits? |
| 19:10 | <Ms2ger> | "pending" or "relevant" |
| 19:12 | <jsbell> | Ah, and click + drag to select things. Obvious... |
| 19:15 | <Ms2ger> | At least it's more obvious than reviewable :) |
| 19:16 | <Ms2ger> | jsbell, bah, I hoped nobody would notice name :) |
| 19:16 | <Ms2ger> | I'll squash if it looks good now :) |
| 19:17 | <jsbell> | Ms2ger: also I don't appear to have checkboxes to sign off on it (I'm not on the reviewer list?) |
| 19:17 | <jsbell> | still learning critic :P |
| 19:17 | <jsbell> | Ms2ger: yep |
| 19:18 | <Ms2ger> | Thanks! |
| 20:27 | <Sebmaster> | annevk: you there? |
| 20:32 | <wanderview> | Domenic: there is no way to stream an upload in chrome canary fetch, right? |
| 20:32 | <Domenic> | wanderview: nope :( |
| 20:32 | <wanderview> | ok |
| 20:33 | <wanderview> | Domenic: the body stream works nicely, though :-) |
| 20:33 | <wanderview> | I'll just do separate POST requests instead of a single POST with a stream |
| 20:53 | <wanderview> | Domenic: I see some pathological buffering from the chrome fetch body stream... chunk lengths of 1077, then 1, then 1077, then 1, then 1077, etc |
| 20:54 | <Domenic> | wanderview: oof, that's gross. Would be worth filing a bug, I bet Yutaka would be happy to take care of it... especially if it's consistently repro-able, but I can imagine it's not. |
| 20:54 | <wanderview> | Domenic: I will when I publish this test case |
| 21:11 | <wanderview> | Domenic: is there any easy way to convert the contents of an ArrayBuffer to a String? |
| 21:11 | <wanderview> | nm, I think I found it |
| 21:12 | <Domenic> | TextEncoder |
| 21:12 | <Domenic> | Or TextDecoder in this case. |
| 21:16 | <wanderview> | thanks |
| 21:19 | <smaug____> | oh, blink might remove support for SMIL |
| 21:19 | <smaug____> | so ++ |
| 21:20 | <TabAtkins> | smaug____: That's the plan, yeah. |
| 21:22 | smaug____ | just uploaded a patch for gecko to fix some event handling oddity in SMIL |
| 21:23 | <smaug____> | need to convince heycam|away to deprecate SMIL in Gecko too |
| 21:24 | <caitp> | which new web standards are hot this season, and which ones are hitting the bargain bin |
| 21:24 | <smaug____> | ACID3 will ofc break, but so what |
| 21:24 | <smaug____> | sw is hot in this season |
| 21:25 | <smaug____> | web components have been hot for some time |
| 21:25 | <smaug____> | (luckily we got it simplified, so it might become a thing real soon) |
| 21:25 | <caitp> | i'm not sure web components will survive another season unless the headaches are fixed |
| 21:26 | <smaug____> | I think all the difficult part of shadow dom are now removed, and Imports is gone |
| 21:27 | <smaug____> | so it is "just" the imperative API for shadow dom distribution and custom elements |
| 21:37 | <wanderview> | Domenic: its not done, but here's the start of my system benchmark for the read() perf question: https://github.com/wanderview/streams-time-echo |