| 07:58 | <annevk_> | wanderview: it seems like there might be some problem with how that skip-servicer-worker flag gets set by the SW specification |
| 11:48 | <annevk_> | philipj: rewriting DOM to not use "name" is a bit more involved than I thought, but getting there I think |
| 11:55 | <philipj> | annevk: sweet! |
| 12:05 | <annevk> | philipj: does look like it's worth it to keep a "qualified name" concept around that just computes to something |
| 12:06 | <annevk> | philipj: the current diff has quite a few prefix is null and name is local name or prefix + ":" + local name is name which is not great |
| 12:26 | <philipj> | annevk: Sure, having it as a concept sounds fine, and in fact matches Blink. Doing it the otherway would make it more explicit where there could be a wasteful string being created, but the spec shouldn't micro-optimize at the expense of readability |
| 12:26 | <annevk> | philipj: the only change I haven't made yet is rename various arguments to qualifiedName |
| 12:26 | <annevk> | philipj: that's probably worth doing too at some point |
| 12:27 | <philipj> | annevk: yeah, some kind of clarity about when it's possible to use a colon in the input and not would be nice |
| 12:27 | <philipj> | if (!isHTMLElement() && attrNode->document().isHTMLDocument() && attrNode->name() != attrNode->name().lower()) |
| 12:27 | <philipj> | UseCounter::count(document(), UseCounter::NonHTMLElementSetAttributeNodeFromHTMLDocumentNameNotLowercase); |
| 12:27 | <philipj> | oops |
| 12:27 | <philipj> | that's some code I just removed and had in my clipboard :) |
| 12:28 | <philipj> | annevk: while I have you here, there's another issue, namely that setAttributeNode and setAttributeNodeNS are simply aliases in Blink, but not in the spec |
| 12:29 | <gsnedders> | philipj: what about createElement/createElementNS? |
| 12:29 | <annevk> | philipj: spec matches Gecko? |
| 12:29 | <philipj> | and when I try to align with the spec, I get a place where I potentially lowercast the localName of an Attr object |
| 12:29 | <philipj> | annevk: I think so, yes |
| 12:30 | <philipj> | gsnedders: those aren't aliases, thankfully :) |
| 12:30 | <philipj> | annevk: so it seems weird, to me, to lowercase an Attr's localName, because we're already normalizing case in createAttribute |
| 12:31 | <philipj> | annevk: so what would you think of simply using the namespaceURI and localName of the attr? |
| 12:31 | <annevk> | philipj: I think that's called out in the spec as a weird case we don't care about |
| 12:31 | <annevk> | philipj: hmm, open an issue and discuss with bz / Ms2ger? |
| 12:31 | <philipj> | it is called out, but that was added before createAttribute lowercased its input, right? |
| 12:32 | <annevk> | philipj: true |
| 12:32 | <philipj> | ok, so I'll file a spec issue |
| 13:49 | <gsnedders> | is there any reasonable way to track a specific section of the HTML spec? |
| 13:54 | <annevk> | gsnedders: not really |
| 14:10 | <rom1504> | hi, are whatwg streams usable in node yet ? |
| 15:09 | <jgraham> | gsnedders: I was just going to merge the travis update pr, especially if master is already failing tests |
| 15:11 | <gsnedders> | jgraham: I still want to keep us having linear history. The lxml breakage looks like a small change in ihatexml is needed |
| 15:12 | <jgraham> | OK, well if you're going to fix I'm not going to complain |
| 15:14 | <gsnedders> | it's a three line fix :) |
| 15:15 | <rom1504> | why isn't the up to date reference implementation there https://www.npmjs.com/package/whatwg-streams ? |
| 15:16 | <gsnedders> | rom1504: a) it isn't a reference implementation; b) the author AFAIK isn't here |
| 15:17 | <rom1504> | https://github.com/whatwg/streams/tree/master/reference-implementation is not a reference implementation ? |
| 15:18 | <rom1504> | my question is how can I use this https://github.com/whatwg/streams/tree/master/reference-implementation (and should I) ? |
| 15:18 | <annevk> | rom1504: maybe Domenic can help you out |
| 15:19 | <annevk> | not sure if he's around |
| 15:19 | <rom1504> | I have no idea whether this is supposed to work, but since this is unpublished and in a subdir, there's no way to use it from node |
| 15:19 | <rom1504> | I'll open an issue on the repo |
| 15:20 | <gsnedders> | jgraham: https://github.com/html5lib/html5lib-python/pull/214 look good to you? |
| 15:21 | <gsnedders> | jgraham: bah, still failing tests :\ |
| 15:22 | <jgraham> | gsnedders: Well it looks like a reasonable change at least, but yeah since it alters the comment you can see that it might fail the tests |
| 15:23 | <gsnedders> | jgraham: coercion in principle shouldn't cause failing tests |
| 15:23 | <gsnedders> | jgraham: the real problem is lxml is still throwing |
| 15:23 | <jgraham> | Oh |
| 15:32 | <annevk> | philipj: thank you for the review, fixing now |
| 15:39 | <gsnedders> | jgraham: plz look at https://github.com/html5lib/html5lib-python/pull/214 again |
| 15:41 | <jgraham> | gsnedders: "contain end" |
| 15:42 | <gsnedders> | jgraham: blargh. apart from that? |
| 15:43 | <jgraham> | Do you still need the += " " if it's going to throw anyway? |
| 15:44 | <gsnedders> | jgraham: it doesn't throw, it's a warning |
| 15:44 | <gsnedders> | jgraham: see everything else in ihatexml |
| 15:47 | <jgraham> | Right, I guess that makes sense |
| 15:47 | <jgraham> | Anyway r+ |
| 15:48 | <gsnedders> | jgraham: basically we ignore test results if datalosswarning is raised |
| 15:50 | <jgraham> | gsnedders: Yeah, I remember that part |
| 16:38 | <gsnedders> | https://github.com/html5lib/html5lib-tests/pull/71#issuecomment-158989019 if anyone can remember about how the list of character references was derived |
| 16:44 | <annevk> | gsnedders: it's part of the build script https://github.com/whatwg/html-build |
| 16:45 | <gsnedders> | annevk: that's what I thought |
| 16:45 | <gsnedders> | annevk: which is odd, given it means the two things are divergent despite being based on the same source data |
| 17:49 | <annevk> | gsnedders: yeah not sure what is going on |
| 17:49 | <annevk> | :/ |