| 07:46 | <annevk> | frewsxcv: it only works on content attributes… |
| 08:47 | <rits> | i just changed one file for this PR https://github.com/whatwg/html/pull/455 but why the other two commits are showing in this which i did 8days ago and it didn't showed up in git diff |
| 08:51 | <annevk> | rits: try "git rebase origin" |
| 08:51 | <rits> | annevk: ok |
| 08:51 | <annevk> | rits: and then use "git push --force" if that did indeed clean things up locally |
| 08:53 | <rits> | git base origin is giving this fatal: Needed a single revision |
| 08:53 | <rits> | invalid upstream origin |
| 08:57 | <annevk> | rits: rebase |
| 08:57 | <annevk> | rits: not base |
| 08:58 | <annevk> | rits: ooh wait, maybe you need git rebase whatwg/origin or some such since you have a forked repository, hmm |
| 08:59 | annevk | is not that great with git |
| 08:59 | <rits> | yes that was the typo its of the rebase only its giving this error only |
| 08:59 | <rits> | annevk: me too |
| 09:00 | <sangwhan> | What does git status say? |
| 09:00 | <rits> | annevk: oh ok this is because i switched directly to the new branch from a different branch and not from master, i think |
| 09:01 | <rits> | sangwhan: nothing to commit, working directory clean |
| 09:03 | <sangwhan> | If you only want the last commit in the PR just make a new branch, cherry pick that refspec and create a new PR |
| 09:04 | <annevk> | MikeSmith: I can no longer build wattsi locally "ld: file not found: /usr/lib/crt1.10.5.o" |
| 09:04 | <annevk> | MikeSmith: seems to be where the problem is |
| 09:04 | <sangwhan> | Technically if you are asking for a pure git branch merge you can simply just rewrite history and force push, but I'm not sure if GH's PR web UI can gracefully handle that |
| 09:06 | <annevk> | Hmm, maybe it's an Xcode thing |
| 09:06 | <rits> | sangwhan: yeah i am making a new PR deleting the first one |
| 09:07 | <sangwhan> | annevk: guessing from the error you need to either symlink that file out from the osx sdk directory or add a linker directive to look for libraries in the osx sdk directory |
| 09:07 | <sangwhan> | Alternative theory is that you don't have the osx sdk |
| 09:08 | sangwhan | has no idea what wattsi is |
| 09:08 | <annevk> | sangwhan: https://github.com/whatwg/wattsi |
| 09:08 | <annevk> | sangwhan: part of the HTML standard |
| 09:09 | <sangwhan> | Ooh, pascal. This is something I haven't seen in a while |
| 09:18 | <sangwhan> | annevk: Try slipping a -L (path to your osx sdk)/usr/lib right before the -l in the fpc call inside compile.sh. |
| 09:19 | <sangwhan> | No idea if it will work, I'm not sure which linker directives fpc acknowledges and passes on |
| 09:46 | <MikeSmith> | annevk: I believe the fix is to update your XCode |
| 09:46 | <MikeSmith> | annevk: somebody else had the same problem a couple few weeks back |
| 09:46 | <MikeSmith> | and I recall that's what the fix was |
| 09:47 | <MikeSmith> | XCode command-line tools |
| 09:47 | <MikeSmith> | I think, more specifically |
| 09:50 | annevk | runs "xcode-select --install" and indeed stuff is downloading... |
| 09:55 | <annevk> | MikeSmith: seems to compile now with sudo... |
| 09:55 | <annevk> | MikeSmith: ton of warnings about linking to an older version than it's being built for |
| 10:17 | <MikeSmith> | annevk: yeah I get those older-version warnings too |
| 10:18 | <MikeSmith> | I think that's actually just due to that version the OS X fpc compiler |
| 10:19 | <MikeSmith> | I think there's nothing OSX-specific in the wattsi sources that would trigger it |
| 10:23 | <annevk> | So much duct tape |
| 10:23 | <MikeSmith> | annevk: you shouldn't need to run it under sudo to get it work |
| 10:24 | <MikeSmith> | if you're sure you have the latest XCode and command-line tools for it, I don't know what would cause it |
| 10:24 | <MikeSmith> | sometimes you have to open the XCode GUI app and accept the license |
| 10:25 | <MikeSmith> | e.g., after you upgrade to a newer OS X version |
| 10:25 | <MikeSmith> | anyway, zcorpan had the same problem a while back I think |
| 11:48 | <annevk> | <script type=module> is pretty exciting |
| 11:48 | <annevk> | 2016 \o/ |
| 11:50 | <MikeSmith> | yeah very cool to see <script type=module> happening |
| 11:51 | <annevk> | MikeSmith: I guess the sudo might not have been needed indeed |
| 11:51 | <annevk> | MikeSmith: so yeah, maybe the freepascal stuff is a bit dated |
| 11:54 | <MikeSmith> | actually I think it might be a common problem with the OS X linker, not specific to freepascal |
| 11:55 | <MikeSmith> | some stuff that OS X library stuff stuff is old and borked in various ways |
| 11:57 | <MikeSmith> | e.g., the OS X libc is out of date to the point that among other things it prevents apps from being able to display emoji-range unicode |
| 11:57 | <MikeSmith> | anyway it's still better than desktop Linux |
| 13:49 | <nox> | annevk: Hopefully that's the last fix on replace a child. :P |
| 13:49 | <nox> | Happy new year you people, btw. |
| 13:51 | <nox> | annevk: "The otherwise can still be its own step. "Otherwise, append attr to element."" |
| 13:51 | <nox> | Do you have guidelines on this? |
| 13:52 | <nox> | You didn't like Otherwise being its own step in replace a child. |
| 13:52 | <annevk> | nox: was it a distinct sentence there? |
| 13:54 | <annevk> | nox: I'm not a 100% sure what the guideline is, but generally if/else would be two steps, but x = cond ? y : z would be one step |
| 13:54 | <nox> | Ok, I see. |
| 13:54 | <nox> | annevk: Let me rebase that. |
| 13:55 | <annevk> | "1. If cond, do x. 2. Otherwise, do y." vs "Let x be 1 if cond, and 2 otherwise." |
| 13:55 | <nox> | annevk: I see. |
| 13:55 | <annevk> | Hopefully one day heycam will formalize it in IDL |
| 13:55 | <nox> | :) |
| 13:56 | <nox> | annevk: What do you think of [UnenumerableNamedProperties] directly in WebIDL, given there would be at least 6 consumers of it? |
| 13:56 | <annevk> | nox: [LegacyUnenumerable] wfm |
| 13:57 | <annevk> | nox: we need to be liberal with "Legacy" in IDL |
| 13:57 | <nox> | annevk: That would work, whatever the name. |
| 13:57 | <nox> | I just believe formalised stuff > prose. |
| 13:57 | <annevk> | people copy-and-paste IDL all over the place without realizing what is happening |
| 13:57 | <annevk> | to some extent, if it leads to folks copy-and-pasting things without understanding them though it can get ugly |
| 13:58 | <nox> | True. |
| 13:58 | <annevk> | hopefully "Legacy" takes care of that, I think it has thus far served enough of a warning sign |
| 13:59 | <nox> | annevk: To be sure: [đź•´]. :P |
| 13:59 | <nox> | annevk: I guess I'll do a PR against WebIDL. |
| 14:00 | <nox> | annevk: This way, we won't have any trouble in Servo to upstream our LegacyUnenumerable patch. ;) |
| 14:00 | <nox> | [to Gecko's WebIDL parser.] |
| 14:02 | <nox> | annevk: https://github.com/whatwg/dom/pull/139#issuecomment-168308800 Wrong PR? |
| 14:02 | <nox> | Because for that PR, the spec is wrong, according to Gecko and WebKit. |
| 14:02 | <nox> | The current spec means that hooks for iframe and whatnot get run twice with setAttributeNode. |
| 14:04 | <annevk> | nox: per 116 Gecko queues two mutation records, no? |
| 14:05 | <nox> | annevk: I checked. Only one. |
| 14:05 | <nox> | annevk: https://github.com/servo/servo/pull/9061#issuecomment-167796252 |
| 14:07 | <nox> | annevk: Did I test that wrong? |
| 14:07 | <annevk> | nox: ah okay, so the only thing Gecko does differently would the placing of the attribute |
| 14:07 | <annevk> | nox: but it does have the special casing that other browsers have too |
| 14:08 | <nox> | The special casing? |
| 14:08 | <annevk> | nox: having a special "replace" algorithm |
| 14:08 | <nox> | annevk: Ok. |
| 14:09 | <annevk> | nox: so your fix is not in line with non-Gecko browsers as you still use remove/append |
| 14:09 | <annevk> | nox: whereas they replace the attribute in place |
| 14:09 | <nox> | annevk: Didn't check that. |
| 14:10 | <annevk> | nox: that's the crux of 116, though the mutation observer thing came up too |
| 14:10 | <nox> | So I fixed the mutation thing, and 116 fixes the rest, that's it? |
| 14:12 | <annevk> | nox: I want you to fix 116 :-) |
| 14:12 | <nox> | Ms2ger and you apparently independently decided I was the new spec janitor… Damn it. :P |
| 14:12 | <nox> | Will try. |
| 14:14 | <nox> | annevk: Do we already have such replacements done somewhere in the spec, from which I could copy the wording? |
| 14:18 | <nox> | annevk: Addressed your other remarks. |
| 14:18 | <annevk> | nox: I'd accept something like "Replace _x_ with _y_ in element’s attribute list."\ |
| 14:18 | <nox> | annevk: Oh, nice. |
| 14:22 | <nox> | annevk: Done. |
| 14:23 | <annevk> | nox: it's a bit nitpicky, but I prefer keeping the <p>s, they got accidentally removed when bikeshed was done |
| 14:24 | <nox> | annevk: Should I add them in the new algo I introduce? |
| 14:24 | <annevk> | nox: yeah, that'd be good |
| 14:24 | <annevk> | ta |
| 14:24 | <nox> | annevk: You should make a commit to fix scope-filtered and whatnot. |
| 14:24 | <nox> | These get changed when I run bikeshed. |
| 14:25 | <nox> | annevk: Done. |
| 14:26 | <annevk> | nox: bikeshed changes the source? |
| 14:26 | <nox> | - <li><a href="https://drafts.csswg.org/selectors-4/#scope-filtered">scope-filtered</a>; |
| 14:26 | <nox> | + <li><a href="https://drafts.csswg.org/selectors-4/#scope_filtered">scope-filtered</a>; |
| 14:26 | <nox> | And the references for WebIDL and Encoding. |
| 14:29 | <annevk> | nox: it does not merge cleanly |
| 14:29 | <annevk> | nox: is your bikeshed uptodate? |
| 14:30 | <nox> | Ah damn. |
| 14:32 | <nox> | annevk: Done. |
| 14:38 | <annevk> | Ugh, whenever I try to get the upstream version it seems I just get an old copy |
| 14:39 | <nox> | I pushed. |
| 14:39 | <nox> | So, let's blame GH? |
| 14:39 | <annevk> | yeah |
| 14:39 | <nox> | Always Blame GitHub. |
| 14:40 | <nox> | annevk: Don't remember if I told you, |
| 14:40 | <nox> | I finally sent a mail to their support, |
| 14:40 | <nox> | they might end up removing their use of replaceState between PR's tabs. |
| 15:03 | <annevk> | I wish they added rebasing and clean history support |
| 15:06 | <annevk> | TabAtkins: how do I suppress "This specification has neither a 'Security Considerations' nor a 'Privacy Considerations' section. Please consider adding both."? |
| 15:22 | <TabAtkins> | annevk: Do what it says. (This was added at the recommendation of the TAG.) |
| 15:22 | <annevk> | TabAtkins: there's no switch? |
| 15:22 | <TabAtkins> | Haven't had need to add one. It only shows up for specs in W3C or WHATWG space. |
| 15:23 | <TabAtkins> | And those specs, per TAG rec, should have such a section. |
| 15:23 | <annevk> | TabAtkins: well, the TAG is welcome to write them for DOM |
| 15:23 | <annevk> | although it depends on what they write whether the PR is accepted, since I have no idea what that would say |
| 15:23 | <TabAtkins> | Feel free to just do a "Security and Privacy Considerations" section with just "This spec has no security or privacy considerations." |
| 15:24 | <TabAtkins> | If that's wrong and there are such concerns, someone'll notice eventually and point it out. |
| 15:25 | <nox> | annevk: Rebasing and clean history support? |
| 15:26 | <nox> | annevk: Use Reviewable. |
| 15:26 | <nox> | annevk: I don't usually like .io apps, but reviewable.io is fine. |
| 15:27 | <gsnedders> | nox: can you easily see what comments refer to after rebasing then? |
| 15:27 | <gsnedders> | nox: esp. if it's just a simple rebase onto masteR? |
| 15:27 | <nox> | gsnedders: That's the main point of it, yes. |
| 15:28 | <nox> | gsnedders: It tracks comments through rebasing, amending… |
| 15:28 | <nox> | gsnedders: And it comments as GH comments. |
| 15:28 | <nox> | gsnedders: And you can publish all comments at once, Ă la Critic. |
| 15:28 | <nox> | gsnedders: You don't need to use it for all PRs, and you don't need any specific action on the repos side to use it. |
| 15:29 | <nox> | gsnedders: So you can try first to review some PRs by feeding their link to the Reviewable UI. |
| 15:29 | <nox> | If you don't like it afterwards, just stop using it. |
| 15:29 | <gsnedders> | nox: ok, from all their literature it was never clear to me that it actually added any real new features given it sounded like there was 1:1 relationship with GH comments |
| 15:29 | <nox> | gsnedders: https://github.com/Reviewable/Reviewable/issues?q=is%3Aissue+servo+is%3Aclosed Servo is one of their biggest users it seems. :) |
| 15:30 | <nox> | OWAI, WE BROKE YOU AGAIN |
| 15:30 | <nox> | gsnedders: Every time the PR's tip change, |
| 15:30 | <nox> | it adds a new "revision" on Reviewable, |
| 15:30 | <nox> | that's what the columns with the eyes are about in file matrices. |
| 15:31 | <nox> | gsnedders: https://cloud.githubusercontent.com/assets/123095/11317947/00de0c9e-9040-11e5-88ec-52b6e0b63577.png |
| 16:16 | <jgraham> | Yeah reviewable is only half bad. Which for a review system is pretty good |
| 22:30 | <caitp> | rietveld works pretty well, apart from being unusable from mobile |
