| 16:35 | <Domenic> | annevk: do you remember why [[CanBlock]] is true for shared workers? |
| 16:37 | <annevk> | Domenic: mainly because there was no compelling reason to set it to false for them, I think |
| 16:37 | <Domenic> | So for service workers it's false because blocking the network is bad, I guess? Not because it's a shared resource? |
| 16:37 | <annevk> | Domenic: arguably it being the only agent cluster instantiating agent that can set it to true might be a reason to set it false |
| 16:37 | <annevk> | Domenic: yeah |
| 16:37 | <Domenic> | Makes sense |
| 16:37 | <Domenic> | And yeah we could potentially flip it |
| 16:38 | <Domenic> | Although I guess that would be a breaking change |
| 16:38 | <annevk> | Firefox has it false at the moment, I believe |
| 16:38 | <Domenic> | Oh nice |
| 16:38 | <Domenic> | Because Firefox is the only affected browser I believe |
| 16:38 | <Domenic> | (IIRC Chrome does not supported nested workers in shared workers?) |
| 16:38 | <annevk> | Domenic: Chrome might still be affected due to Atomics.wait() not throwing |
| 16:39 | <annevk> | Domenic: but that could be true; I have a hard time remembering because I never played with that myself |
| 16:39 | <Domenic> | Yeah, true, "affected", but not web-compat issues (unless someone's doing something really weird) |
| 16:55 | <annevk> | Domenic: if at some point you could give me some quick pointers to how Bikeshed's boilerplate system fits together that would help |
| 16:56 | <annevk> | Domenic: I'm having a hard time figuring out how the Commit Snapshots come together now |
| 16:56 | <Domenic> | annevk: so commit snapshots partly predate the boilerplate system so they don't use all the modern features that RDs do |
| 16:57 | <Domenic> | https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh#L106-L110 basically patches a lot of the existing metadata, using WHATWG defaults as the base |
| 16:57 | <Domenic> | WHATWG defaults are done in https://github.com/tabatkins/bikeshed/blob/master/bikeshed/boilerplate/whatwg/defaults.include and https://github.com/tabatkins/bikeshed/blob/master/bikeshed/boilerplate/whatwg/computed-metadata.include |
| 16:58 | <Domenic> | I think the ideal would be to create a computed-metadata-LS-COMMIT.include, like https://github.com/tabatkins/bikeshed/blob/master/bikeshed/boilerplate/whatwg/computed-metadata-RD.include |
| 16:59 | <Domenic> | Maybe also a head-LS-COMMIT to replace the Text Macro stuff |
| 16:59 | <Domenic> | Although I dunno, getting the SHA in there would be trickier |
| 16:59 | <Domenic> | Any particular questions? |
| 17:00 | <TabAtkins> | Hm, what's the SHA from? |
| 17:00 | <Domenic> | Scripts |
| 17:00 | <Domenic> | It would have to be a new text macro |
| 17:00 | <Domenic> | https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/deploy.sh#L33 |
| 17:01 | <TabAtkins> | Hmmm, I already extract the repo information, I could just make that available as a predefined macro. |
| 17:35 | <annevk> | TabAtkins: wait you look at whatwg/dom when you get dom.bs? |
| 17:35 | <TabAtkins> | If you don't specify a `Repository` metadata, I check if the document is in a git repo and infer the repo metadata from that. |
| 17:38 | <annevk> | TabAtkins: how does that work with the CLI? |
| 17:38 | <annevk> | TabAtkins: sorry, the api.csswg.org thingie |
| 17:38 | <TabAtkins> | Oh, it doesn't. No git repo there, can't infer anything. |
| 17:38 | <annevk> | TabAtkins: that's what we use |
| 17:38 | <TabAtkins> | Ok then yeah, y'all will have to keep doing it yourself. |
| 17:39 | <TabAtkins> | Out of curiosity, why y'all still using the API like that? It's so easy to just do it locally in a travis or whatever. |
| 17:39 | <annevk> | Getting Travis to fetch all of bikeshed each time seems worse? |
| 17:41 | <TabAtkins> | I mean, bandwidth is free. ^_^ |
| 17:41 | <annevk> | TabAtkins: it seems bad to use more computing resources than necessary |
| 17:43 | <TabAtkins> | if you insist |
| 17:43 | <a-ja> | TabAtkins, https://techcrunch.com/2020/03/25/88-out-of-top-200-u-s-cities-have-seen-internet-speeds-decline-this-past-week-3-cities-by-more-than-40/ |
| 17:43 | <a-ja> | :) |
| 17:44 | <a-ja> | "only" down 20% here |
| 17:44 | <annevk> | Domenic: why would getting the SHA into a template be trickier? Some of those files already seem to look at environment variables such as SHORTNAME and such |
| 18:24 | <annevk> | Domenic: note that even for computed-metadata-RD.include we'd need the SHA in there as we put it in the title |
| 18:29 | <annevk> | TabAtkins: can includes use md-Text-Macro? |
| 18:29 | <TabAtkins> | Yeah, the `md-` flag syntax is just a way of adding metadata; you can any of that via <pre class=metadata> or any of the metadata includes. |
| 18:30 | <TabAtkins> | https://tabatkins.github.io/bikeshed/#metadata-text-macro |
| 18:31 | <annevk> | great, then I can just pass the SHA in |
| 18:31 | <annevk> | I guess I'll put something together tomorrow, bit late now |
| 18:31 | <annevk> | thanks! |