| 01:57 | <TimothyGu> | glad to see that `document.open`/`write` makes a cameo ;) |
| 02:10 | <MikeSmith> | Domenic: in the MDN annos, Iām noticing a weird bug that despite having spent time stepping through the code, I still have no insight about why it might be happening |
| 02:11 | <MikeSmith> | the bug is that in single-page output, some MDN annos that are present in the multipage output are not present in the single-page output |
| 02:11 | <MikeSmith> | compare https://html.spec.whatwg.org/multipage/webappapis.html#the-promiserejectionevent-interface to https://html.spec.whatwg.org/#the-promiserejectionevent-interface |
| 02:12 | <MikeSmith> | that bug is causing literally hundreds of annos to not appear in the single-page output |
| 02:13 | <MikeSmith> | can you think of any difference in how we do single-page output that might be the culprit? |
| 02:15 | <Domenic> | MikeSmith: I don't have enough of wattsi loaded into my head to really answer that, but I do remember vaguely running in to this sort of mystifying difference between the two... I can try to take a better look tomorrow. File a quick issue so that I have it in my inbox? |
| 02:15 | <MikeSmith> | Domenic: OK will do |
| 02:15 | <MikeSmith> | thanks |
| 02:28 | <MikeSmith> | https://github.com/whatwg/wattsi/issues/111 |
| 02:28 | <MikeSmith> | maybe one of the many other Free Pascal coders who hang out here will step in to fix it š |
| 03:09 | <devsnek> | did import.meta.currentScript ever get past the multiple script issue |
| 14:52 | <Domenic> | devsnek: nope |
| 14:53 | <devsnek> | i guess you'd end up needing some sort of crazy event model for when a script uses the instance |
| 16:00 | <annevk> | Domenic: wanna do the .pr-preview.json stuff today? |
| 16:00 | <Domenic> | annevk: yep, working on it now :) |
| 16:00 | <annevk> | \o/ |
| 16:10 | <annevk> | Domenic: if you know who from Google to copy on https://github.com/whatwg/html/pull/5425 that'd be good |
| 16:11 | <Domenic> | annevk: Eric Law is probably the right person for Chromium but maybe we can get someone from Google... |
| 16:12 | <annevk> | k |
| 17:04 | <ecobos> | TimothyGu: ping? |
| 17:04 | <TimothyGu> | ecobos: pong |
| 17:05 | <ecobos> | TimothyGu: hey, I was unsure whether https://bugzilla.mozilla.org/show_bug.cgi?id=1627285#c1 was incomplete or something (or maybe I just didn't parse it properly, not a native english speaker) |
| 17:05 | <TimothyGu> | oops, clicked send too early |
| 17:05 | <ecobos> | TimothyGu: did you plan to send a fix? Or should I go ahead and send the patch? It's pretty trivial to fix |
| 17:06 | <TimothyGu> | I meant to say that I could help fix it in Firefox |
| 17:06 | <TimothyGu> | Yeah I actually just wrote one |
| 17:06 | <ecobos> | TimothyGu: ah, if you want to I won't stop you :-) |
| 17:06 | <ecobos> | TimothyGu: glad I asked before writing it then ;) |
| 17:06 | <ecobos> | TimothyGu: thanks! |
| 17:18 | <annevk> | Domenic: hmm GitHub is having many issues, so not gonna risk it now |
| 17:18 | <Domenic> | Aww OK |
| 17:19 | <annevk> | Domenic: how does Bikeshed get all the relevant data from a PR number alone? |
| 17:19 | <Domenic> | annevk: it turns out that's all the data you really need |
| 17:19 | <Domenic> | Previously we were linking to the PR's head commit |
| 17:19 | <Domenic> | Which required commit SHA + repo owner |
| 17:19 | <Domenic> | But if you take a step back, why would that be a good idea? Linking to the PR itself is much nicer. |
| 17:20 | <Domenic> | It just needed some extra work to add a dedicated PR preview template instead of reusing the commit snapshot one. |
| 17:21 | <annevk> | Ah okay, I guess it is nicer to link to the PR as it might also change over time, just like the PR |
| 17:21 | <annevk> | Domenic: you'd kinda think that pr-preview already has the PR number btw as that's used for the filename |
| 17:22 | <Domenic> | Yeah it does, you just need to pass it to Bikeshed. |
| 17:23 | <annevk> | Oh right, these are Bikeshed instructions. Next level would be { src: "....bs", type: "whatwg" } I guess |