| 10:42 | <annevk> | MikeSmith: could it be that wattsi is still not feeling well? Getting build errors after a rebase on something that was working before |
| 10:42 | <annevk> | MikeSmith: https://github.com/whatwg/html/pull/5491 |
| 10:46 | MikeSmith | looks |
| 10:48 | <MikeSmith> | annevk: yeah it’s still broke |
| 10:48 | <MikeSmith> | oh wait |
| 10:48 | <MikeSmith> | not “still” |
| 10:49 | <MikeSmith> | I was thinking that it was caused by the Python 3 changes |
| 10:49 | <MikeSmith> | but those are only in https://github.com/whatwg/html-build/pull/227 and not merged yet |
| 10:51 | <MikeSmith> | > /bin/sh: 1: /whatwg/wattsi/build.sh: not found |
| 10:51 | <MikeSmith> | that doesn’t look familiar |
| 10:59 | <annevk> | MikeSmith: let's wait for Domenic then |
| 10:59 | <annevk> | (it's not really blocking me, was just curious) |
| 11:00 | <MikeSmith> | well I realize now what caused it |
| 11:00 | <MikeSmith> | https://github.com/whatwg/wattsi/commit/9f5e9e75bf1071fd8bc22c5765266b89305b0cce |
| 11:00 | <MikeSmith> | we merged that without updating html-build to align with that change |
| 11:38 | <noamr> | annevk: hola! wanted to chat re. https://github.com/whatwg/html/pull/5574 |
| 11:38 | <noamr> | (intrinsic image resolution) |
| 13:27 | <annevk> | noamr: best to leave a question |
| 13:27 | <noamr> | annevk: sure! I am struggling with how to add that algorithm into the HTML spec, because EXIF and image metadata are not things that are well defined in HTML-land and are codec-related to an extent. Was thinking to add a passage about "Updating the image metadata", where the orientation/resolution/size are read from the image metadata, but without referring normatively to EXIF. Maybe adding a non-normative note about EXIF |
| 13:28 | <noamr> | (sorry, had this written and forgot to press Enter) |
| 13:28 | <noamr> | I actually created a new PR with this approach... but it's not clear where HTML stops and image codecs start wrt standartization |
| 13:28 | <annevk> | noamr: why can we not reference EXIF normatively? |
| 13:30 | <noamr> | Since JPEG/GIF/PNG etc. are not referenced normatively, and EXIF is embedded in them. I don't mind referencing it normatively though |
| 13:31 | <annevk> | noamr: does EXIF define the embedding for each of those? |
| 13:31 | <annevk> | I guess we currently only require PNG encoding, sigh |
| 13:32 | <noamr> | yes, but it can be potentially be defined in other metadata formats like XMP. |
| 13:33 | <annevk> | noamr: should UAs support those though? |
| 13:34 | <noamr> | probably not for now. |
| 13:34 | <annevk> | noamr: so I guess we want the abstract "obtain image" that returns an image bitmap + metadata and that algorithm can then be a bit vague about formats, but it could say that if UAs support GIF, they must do X for EXIF |
| 13:35 | <annevk> | noamr: that way we sidestep requiring formats, but do require a particular metadata strategy if the format is supported |
| 13:36 | <annevk> | noamr: perhaps Domenic finds it reasonable to start requiring some baseline image formats though, certainly seems reasonable to me |
| 13:43 | <noamr> | annevk: Sure, I'll do that. Most codecs support EXIF, and I can define that if the image codec supports EXIF embedding, then metadata extraction should use that. |
| 13:43 | <noamr> | annevk: I'm doing this for density correction, but shouldn't this be also done for orientation? Maybe a follow up would be to be more explicit about reading orientation from EXIF |
| 13:44 | <annevk> | noamr: yeah, though orientation has this weird quirk with the CSS property |
| 13:45 | <noamr> | annevk: this is kinda similar, with the image-resolution CSS Property. However, I didn't bother with it since nobody seems to be planning to implement image-resolution in the foreseeable future :) |
| 13:45 | <annevk> | there's also imageOrientation in <canvas> |
| 13:46 | <annevk> | I really rather not have CSS properties as it's rather unclear how they apply in a number of places |
| 13:46 | <annevk> | I guess we also forgot to test EXIF + imageOrientation :/ |
| 13:47 | <noamr> | yea I agree - not dealing with CSS for now. |
| 13:47 | <noamr> | thanks annevk, will come up with a new patch soonish |
| 14:30 | <domfarolino> | annevk: for your review of #5573, should I instead say when setting the loading attribute, run these steps: [possibly set the ready to be lazy loaded flag]? Is that more accurate, since it lists the requirement? |
| 14:35 | <annevk> | domfarolino: "when X is set, the user agent must set Y" (see other attribute UA requirements) |
| 14:35 | <annevk> | domfarolino: does make me wonder what happens if you set it and then remove it, and edge cases like that |
| 14:49 | <domfarolino> | annevk: Yeah so an interesting case to test would be 1) Setting it to something 2) Entering #updating-the-image-data 3) Setting it to something else when the micro task is queued, 4) Asserting that the rest of the algorithm acknowledges the latest ‘loading’ value |
| 14:49 | <domfarolino> | annevk: otherwise if the image is just deferred, setting the attr to eager and then quickly removing it shouldn’t be any different than just setting it to eager |
| 14:51 | <annevk> | domfarolino: yeah, but you can test the latter too as implementations might well do something else |
| 14:51 | <domfarolino> | True |
| 16:32 | <domfarolino> | annevk: Do you know of a firefox bug or iframe lazyloading? Or can I just reuse https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 |
| 17:35 | <annevk> | domfarolino: https://bugzilla.mozilla.org/show_bug.cgi?id=1622090 |
| 18:55 | <domfarolino> | Domenic: Can you explain what you mean by "The changes from 5/6 to 4/6 passing in Blink/WebKit make me a bit worried that the refactoring broke something". When I `./wpt serve` on the latest PR, and navigate to a test in Chrome stable, I still see "5 tests", with at most 1 failing |
| 18:55 | <domfarolino> | (Admittedly I haven't run them all, because they take a little while) |
| 19:03 | <Domenic> | domfarolino: I was looking at https://wpt.fyi/results/html/semantics/scripting-1/the-script-element/moving-between-documents?diff&filter=ADC&run_id=554640001&run_id=567930001 |
| 19:03 | <Domenic> | and https://wpt.fyi/results/html/semantics/scripting-1/the-script-element/moving-between-documents?diff&filter=ADC&run_id=558510001&run_id=539730001 |
| 19:04 | <domfarolino> | Ooh I don't think I knew you could do that. OK I'll check it out |
| 19:17 | <domfarolino> | Domenic: Ah, so my refactoring made it "better". Will comment back on the thread |
| 19:19 | <Domenic> | This button is magic https://usercontent.irccloud-cdn.com/file/gSNQYtLq/wpt-fyi.png |
| 19:21 | <domfarolino> | Yassss OK good to know, that is lit |
| 19:26 | <Domenic> | TabAtkins: ping on https://github.com/whatwg/html-build/pull/227#issuecomment-632401568 |
| 19:26 | <TabAtkins> | thanks for the ping; i'll handle it today |
| 22:30 | <gsnedders> | https://github.com/html5lib/html5lib-tests/pull/126 if anyone wants a trivial parser test PR |
