| 14:09 | <annevk> | noamr: I still see multiple _img_ variables |
| 14:11 | <noamr> | annevk: right. I will add a var that points to the req's img, will make he code more succinct |
| 14:11 | <annevk> | noamr: it's also not clear to me that the image request has intrinsic dimensions |
| 14:12 | <annevk> | Some of this is probably because the current description of this element is still rather messy |
| 14:12 | <annevk> | The same-origin check can't be that way either as this seems to ignore redirects and such, instead we need to check the opaqueness of the response |
| 14:13 | <annevk> | noamr: I'd also prefer if for new internal fields that we introduce we clearly define the types and not just their initial value |
| 14:13 | <noamr> | it's copied from same-origin checks of canvas |
| 14:13 | <annevk> | yeah that's also wrong |
| 14:13 | <noamr> | regarding request - the image has intrinsic dimensions, and they're assigned before "update the image metadata" |
| 14:15 | <annevk> | but update the image metadata only has an image request, not an img |
| 14:15 | <annevk> | afaict |
| 14:15 | <noamr> | image request has an img |
| 14:17 | <noamr> | re. same-origin: is this necessary to put it in the spec at this point? currently image-resolution is not implemented so it's inert for the purposes of resolution. The general direction is set, I think that it needs to be define when Tab gets to fixing the spec for image-orientation |
| 14:18 | <noamr> | if it is, what would be a way to go about it? |
| 14:21 | <noamr> | (the same-origin thing is also why we're defining the new struct, which is currently not really in use) |
| 14:23 | <noamr> | annevk: re. types - is there a standard type for width+height struct? having a hard time finding it in the html spec |
| 14:25 | <annevk> | just spelling it out would suffice for now |
| 14:26 | <annevk> | "undefined or a struct consisting of a width and a height" or some such |
| 14:26 | <annevk> | And yeah, we do want the details to be ironed out before making changes |
| 14:26 | <annevk> | See https://whatwg.org/working-mode#changes |
| 14:29 | <noamr> | ok annevk. any pointers about a more proper place to pull the cross/same-origin definition from? |
| 14:30 | <annevk> | noamr: I think CORS-cross-origin is what we want here |
| 14:31 | <annevk> | (also works for non-CORS stuff, prolly needs a better name) |
| 14:31 | <annevk> | noamr: or the inverse which is also defined, CORS-same-origin |
| 14:33 | <noamr> | gotcha annevk, thanks |
| 14:36 | <noamr> | I fixed all of it now, I believe. (new PR uploading) |
| 20:00 | <EveryOS> | So I guess my edit button just doesn't exist https://usercontent.irccloud-cdn.com/file/ukotJc9X/image.png |
| 20:00 | <EveryOS> | I wanted to un-stupidify my idea |
| 20:02 | <EveryOS> | Discourse was letting me edit my post fine yesterday |
| 20:03 | <EveryOS> | I'll have to use a comment instead, I guess. |
| 21:45 | <EveryOS> | Ok, I've typed up my revisions to my idea, just need to log into Discourse and submit |
| 21:45 | <EveryOS> | It's also long. I feel like I'm giving too many walls of text |
| 21:51 | <EveryOS> | If I decide that I still don't like this later on, I'll just flag my topic for deletion. |
