| 11:15 | <annevk> | andreubotella: it seems that only Chrome does newline normalization |
| 11:17 | <andreubotella> | annevk: The send-file-form-controls.tentative.html tests are passing on webkit on Linux, so webkit is doing newline normalization when building the multipart/form-data payload, not when constructing the entry list. |
| 11:18 | <annevk> | andreubotella: okay, I do recall the spec having newline normalization for some form stuff |
| 11:18 | <andreubotella> | https://html.spec.whatwg.org/#append-an-entry |
| 11:22 | <annevk> | andreubotella: yeah, just found that, perhaps Infra should define Windows-normalize newlines |
| 11:23 | <annevk> | I also wonder if there's no coverage for that already |
| 11:24 | <andreubotella> | I skimmed the tests, and there didn't seem to be anything, but maybe I missed something |
| 11:25 | <annevk> | Yeah, not seeing anything either |
| 11:54 | <andreubotella> | I'm not sure exactly when FormData was introduced, but webkit's behavior is making me thing about how new features can make what was previously a web-inobservable detail web-observable |
| 11:55 | <annevk> | andreubotella: yeah, we/I didn't do enough due diligence back then; I think I also didn't realize all the implications when adding fetch() support for it |
| 11:58 | <annevk> | It's pretty old, https://www.w3.org/TR/2010/WD-XMLHttpRequest2-20100907/#the-formdata-interface is the earliest draft I could find |
| 11:59 | <annevk> | And unfortunately I think we lost history twice, once when migrating from CVS and once when migrating from Mercurial |
| 12:30 | <andreubotella> | annevk: hopefully these comments I just added clarify the escapes |
| 12:47 | <annevk> | andreubotella: do you plan to file bugs for the non-tentative tests? |
| 12:48 | <annevk> | andreubotella: and do you need me to land the PR? Any preferred commit message, the original one? |
| 12:51 | <andreubotella> | annevk: The original commit message works for me |
| 12:51 | <andreubotella> | and I'll file bugs for the newline normalization |
| 12:52 | <andreubotella> | the rest of failures in non-tentative tests are the safari crash |
| 15:09 | <andreubotella> | annevk: https://bugzilla.mozilla.org/show_bug.cgi?id=1657844 |
| 15:09 | <andreubotella> | https://bugs.webkit.org/show_bug.cgi?id=219086 |