| 03:05 | <Richard Gibson> | bakkot: any ideas about why ecmarkup is failing to populate <emu-import>s in ECMA-402? https://github.com/tc39/ecma402/runs/7104742995?check_suite_focus=true#step:6:1 |
| 03:16 | <bakkot> | Richard Gibson: looks like it is to me? |
| 03:16 | <bakkot> | you're cating spec/index.html, which is the input, though |
| 03:17 | <Richard Gibson> | no, out/index.html is only 7.8K |
| 03:17 | <Richard Gibson> | please disregard the confusing cat |
| 03:20 | <bakkot> | ah, hm, let me see. |
| 03:26 | <Richard Gibson> | updated to output out/index.html contents: https://github.com/tc39/ecma402/runs/7104920026?check_suite_focus=true#step:6:1 |
| 03:27 | <Richard Gibson> | and of course everything works fine locally |
| 03:27 | <bakkot> | I can repro locally |
| 03:27 | <bakkot> | by rm -rf'ing node_modules and out |
| 03:28 | <bakkot> | poking through the debugger, seems to be because https://github.com/tc39/ecmarkup/blob/3a872ca5c19872bf1ed5cd84ff8db1ecf7c3ddef/src/Spec.ts#L1910 is, for some reason, failing - looks like it's case-sensitive, when it really should not be |
| 03:28 | <bakkot> | don't know why that would have changed though |
| 03:28 | <Richard Gibson> | jsdom? |
| 03:32 | <bakkot> | looks like the selectors come via https://github.com/dperini/nwsapi, which had its first release in three years six days ago |
| 03:32 | <bakkot> | so that's a very likely candidate |
| 03:34 | <bakkot> | yeah, pinning "nwsapi": "2.2.0", seems to fix it locally |
| 03:34 | <bakkot> | I'll file the actual bug but that's a fine workaround for now |
| 03:34 | <bakkot> | in the mean time, I suggest committing your package-lock, so this doesn't happen |
| 03:34 | <bakkot> | you should always commit your package-lock |
| 03:38 | <Richard Gibson> | I didn't even realize we weren't. There's an .npmrc with package-lock=false! 😱 |
| 03:49 | <bakkot> | https://github.com/dperini/nwsapi/issues/57 for posterity |
| 04:02 | <Richard Gibson> | thanks for being so responsive |
| 21:03 | <ljharb> | I didn't even realize we weren't. There's an .npmrc with package-lock=false! 😱 |