| 14:12 | <rkirsling> | 100% agreement; even when I know somebody happened to mean otherwise, 👀 is "wide-eyed", so basically "wow they just said that" or "intense stare for comedic purposes" |
| 14:16 | <rkirsling> | the fact that it's one of the GH emoji reaction set has never made any sense to me; there is no facial expression that means "I have seen this", because that's literally not an emotion |
| 14:18 | <Ashley Claymore> | I think it has to be wide eyed, to make it clear that it's not "I am suspicious of this" |
| 14:20 | <rkirsling> | 👍️ and ✅️ are both appropriate for "noted", but they're contextually ambiguous with approval; I guess to resolve that you'd literally need a 🆒 that reads "READ" |
| 14:22 | <Josh Goldberg 💖> | FWIW I've typically seen 👀 used to indicate "looking". E.g. for PRs indicating a comment is being looked at / worked on. Which I've assumed is why GitHub included them in their emoji reactions. |
| 14:22 | <rkirsling> | indeed. I understand it logically but it doesn't make sense visually |
| 14:23 | <rkirsling> | actually, 👁️ would be just fine |
| 14:23 | <rkirsling> | because that's "watching" |
| 14:23 | <rkirsling> | which is close enough to "looking" |
| 14:24 | <nicolo-ribaudo> | 👁️ makes me feel like somebody is "keeping an eye" on me, in a negative way |
| 14:25 | <rkirsling> | right. but at least they're not appalled 😆 |
| 15:28 | <nicolo-ribaudo> | What do we use for build previews of PRs in the 262 repo? I'd like to do the same for source maps |
| 16:04 | <Ashley Claymore> | 👁️ makes me feel like somebody is "keeping an eye" on me, in a negative way 👁️ 👁️ |
| 16:30 | <shu> | 👁️👄👁️ |
| 16:36 | <nicolo-ribaudo> | \ 🎩 \ 👁️👃👁️ \ 👄 |
| 17:10 | <bakkot> | we use something bespoke but I recommend using ron's workflow for just using github pages instead: https://github.com/tc39/template-for-proposals/issues/30 |
| 17:18 | <nicolo-ribaudo> | Oh we currently have a PR with something very similar to that, but I was annoyed by the fact that it doesn't clean up the gh-pages folder once the PR gets merged/closed. |
| 17:23 | <bakkot> | ah |
| 17:23 | <bakkot> | yeah we're pushing to AWS I think |
| 17:23 | <bakkot> | I recommend simply deciding not to care about the contents of the gh-pages folder |
| 17:24 | <bakkot> | but that said it would be pretty easy to have an another action to clean it up for you with https://github.com/marketplace/actions/github-list-pull-requests |
| 17:24 | <bakkot> | (or whatever) |