| 18:47 | <ljharb> | how come https://tc39.es/ecma262/#sec-array.prototype.splice has two different variables for "the number of elements in items", where it's not changed between the usages? is that just redundant? |
| 18:51 | <bakkot> | looks redundant to me, yup |
| 19:06 | <jmdyck> | The 'duplication' first appears in ES6. ljharb , your PR #2595 simplified splice, including simplifying the definition of insertCount, but I guess you didn't notice the duplication at that time. |
| 19:15 | <ljharb> | aha, thanks |
| 19:16 | <ljharb> | i'll make a quick PR to clean it up |
| 21:15 | <shu> | jmdyck: how are https://github.com/tc39/ecma262/pull/2716 and https://github.com/tc39/ecma262/pull/2625 layered? |
| 21:16 | <shu> | should i review #2625 first then #2716? |
| 21:19 | <jmdyck> | That'd probably be best. |