| 00:37 | <jmdyck> | PerformPromiseAll's abstract closure defines _index_, which is also defined outside the closure, which I think was discouraged at some point. Doesn't appear in Editorial-Conventions though. (Abstract closures don't appear at all in Editorial-Conventions.) |
| 01:50 | <Michael Ficarra> | yeah, we generally try to avoid shadowing |
| 01:51 | <Michael Ficarra> | in this case, we should probably just inline it, since there's only 1 usage site |
| 02:25 | <Michael Ficarra> | @jmdyck I opened https://github.com/tc39/ecma262/pull/3732 |
| 02:41 | <bakkot> | I don't love doing a[b[c]] |
| 02:41 | <bakkot> | it's obviously legal but we don't usually do that |
| 02:56 | <jmdyck> | ecmaspeak is okay with it, dunno about esmeta |
| 02:57 | <jmdyck> | esmeta check passed, so i guess it's okay |
| 04:45 | <Michael Ficarra> | also ecmarkup seems fine with it |
| 04:46 | <Michael Ficarra> | it's highlighting the field properly when I select it |
| 04:46 | <Michael Ficarra> | I think it's fine |
| 10:55 | <jmdyck> | (internal slot, not field) |
| 17:26 | <Michael Ficarra> | same notation, ecmarkup doesn't know the difference |
| 17:29 | <Michael Ficarra> | @shu this PR is just waiting on your review: https://github.com/tc39/ecma262/pull/3009#issuecomment-3611085325 |
| 18:19 | <jmdyck> | 3730 has same problem with _alreadyCalled_ |
| 18:36 | <Michael Ficarra> | hmm, I could rename the outer alias in that one, but there's also not much point in the inner alias, so I'll probably just inline that one as well |
| 18:37 | <Michael Ficarra> | that alias and the index alias mostly only existed because of those steps' origin as a separate AO, not because it would be how we would write it from scratch |
| 19:24 | <bakkot> | shall we stamp https://github.com/tc39/ecma262/pull/3009 as ready? |
| 21:48 | <jmdyck> | I'm curious why [[AlreadyCalled]] is sometimes a Boolean, and sometimes a Record containing a Boolean. (But I doubt I'd understand the answer.) |
| 21:49 | <bakkot> | for PerformPromiseAllSettled, it's shared state for both the onFulfilled and onRejected callbacks |
| 21:49 | <bakkot> | so we make it a record so that both functions share the same value |
| 21:50 | <bakkot> | this doesn't apply to PerformPromiseAll or PerformPromiseAny because those just have a single callback (onFulfilled and onRejected respectively), so they don't need to share that state with anything else |
| 21:51 | <jmdyck> | okay, thx |