| 05:39 | <Michael Ficarra> | I have no preference between the two, but if you do, you should try to describe what it is about it that makes you prefer the former so that others can try to maintain consistency |
| 05:42 | <bakkot> | there's just too much going on in one line is all |
| 05:47 | <bakkot> | if you want a rule to write down, something like
where "complex" is deliberately handwavy |
| 15:50 | <Michael Ficarra> | we have "if an early-exiting if/else has just two branches (i.e. not an if-else cascade like in some Math functions), and the two branches are substantially similar and short, prefer a single step", which we could generalise by removing "early-exiting" |
| 15:51 | <Michael Ficarra> | anyway, feel free to push up a commit with whatever adjustments you prefer |
| 16:37 | <bakkot> | I don't actually prefer a single step in those cases, necessarily, rather it's that I prefer not a single step in the cases where it is not similar and short |
| 16:38 | <Michael Ficarra> | so iff? |