03:16
<ljharb>
i rebased https://github.com/tc39/ecma262/actions/runs/23778570093/job/69285769804?pr=3714 and the later version of ecmarkup is failing. It’s on grammar nodes so the fix isn’t obvious to me.
03:19
<Richard Gibson>

error: duplicate definition "PropertyDefinitionNodes"

looks like it might be a bad rebase. I moved that SDO earlier today: https://github.com/tc39/ecma262/commit/a6a9c7b3c62802b67cca325013d332f85832bb9c

03:25
<ljharb>
Crap, my bad. in that case, can you rebase it so it’s just the two commits, but working properly? feel free to start with the previous tip
03:42
<Richard Gibson>
just pushed
03:43
<Richard Gibson>
relevant checks passed
03:46
<Richard Gibson>
other checks passed as well
04:01
<Richard Gibson>
ljharb 👍
05:52
<ljharb>
Michael Ficarra: we still need the ES2026 blurb for the bottom of the intro - if you push to a branch (no PR needed) i'll pull it in and cut the edition tomorrow
06:09
<ljharb>
also, shouldn't https://github.com/tc39/ecma262/pull/3759 be included as well, since it has stage 4? or was that not in time for ES2026
06:26
<Michael Ficarra>
nope, Temporal was not going to be reviewed for es2026
06:26
<Michael Ficarra>
that was part of our discussions with the Temporal champions months ago
06:38
<Michael Ficarra>
I've made the 2026 branch: https://github.com/tc39/ecma262/tree/es2026
06:38
<Michael Ficarra>
I'll post the opt-out review period thread to the Reflector tomorrow morning (Tuesday, 31 March)
06:39
<Michael Ficarra>
one thing we forgot to do was add an update blurb to the end of the introduction and update the editor list
06:39
<ljharb>
we still need to update the intro before cutting the edition tho
06:39
<ljharb>
^
06:40
<Michael Ficarra>
we can take care of that at the next editor call, or if anyone's feeling ambitious, they can start a draft and send a PR
06:41
<ljharb>
iirc the optout can't start until the actual candidate is out, and that needs the blurb
06:41
<Michael Ficarra>
I have no problem with us making that change during the review period, as it's all non-normative
06:41
<ljharb>
yeah, i suppose i can finish cutting it now and just update it later
06:42
<Michael Ficarra>
we make other small non-normative things when needed, that's not unusual
07:37
<ljharb>
https://github.com/tc39/ecma262/releases/tag/es2026-candidate-2026-03-31