TC39 Editors
2026-04-08
plaintext logs
prev next
source on github
15:30
<Michael Ficarra>
if we have time at one of the next few editor calls, I think we should do some PR prioritisation
15:30
<Michael Ficarra>
a couple of @jmdyck's model-everything-as-records PRs are high priority IMO
15:30
<Michael Ficarra>
also ERM and Temporal of course
21:29
<Michael Ficarra>
oops: I accidentally just pushed a commit to main (why does GitHub let me do that?!)
21:30
<Michael Ficarra>
anyway, I pushed a revert immediately and I'll open a PR for it instead
21:42
<Michael Ficarra>
btw, @ljharb is there a way we can make the "publish PR preview" job so that no more than one is running at the same time?
21:42
<Michael Ficarra>
whenever 2 or more are running at the same time, 1 will succeed and the others will all fail and then I have to re-run them one by one
22:10
<ljharb>
not easily
22:10
<ljharb>
the proper way would be to have the PR workflow write to a queue, and a dispatched workflow process the queue
22:10
<ljharb>
also i can force push out the mistaken commit, nbd
22:42
<Michael Ficarra>
that sucks, other CI systems I've used make that super easy to do
22:42
<rbuckton>

Branch protection is enabled, but @tc39/ecma262-editors has the admin role so it can probably bypass it.

From https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches?utm_source=copilot.com#about-branch-protection-rules

By default, the restrictions of a branch protection rule don't apply to people with admin permissions to the repository or custom roles with the "bypass branch protections" permission. You can optionally apply the restrictions to administrators and roles with the "bypass branch protections" permission, too. For more information, see Managing custom repository roles for an organization.

22:43
<Michael Ficarra>
@rbuckton I do want to be able to bypass it from the UI when I click the checkbox if I need to do that, but I don't want it to just auto-bypass it from a push at the CLI!
22:44
<Michael Ficarra>
there's almost no point in having branch protections at that point
22:45
<rbuckton>
Also, github has merge queues, we just don't have it enabled in our branch protection rules:
22:46
<rbuckton>
ah, here's the branch protection rule about administrators:
22:46
<Michael Ficarra>
that's not what I'm looking for @rbuckton, the "publish PR preview" job is part of CI, not part of merging
22:47
<rbuckton>
Ah, true
22:47
<Michael Ficarra>
I need a CI semaphore
22:54
<rbuckton>
https://dev.to/mktcode/make-github-workflows-run-consecutively-265f
22:56
<Michael Ficarra>
I think this does what I want: https://github.com/marketplace/actions/mutex-action
23:01
<Michael Ficarra>
🤞 https://github.com/tc39/ecma262/pull/3821
23:16
<Michael Ficarra>
also, should we periodically purge the closed PRs from the gh-pages branch to keep the repo size down?