| 15:04 | <linus> | I always assumed that the spec cycles though decimal, alphabet, roman steps indefinitely but it looks like after six nesting levels it just uses roman - why is that? |
| 15:05 | <linus> | e.g. GDI step 12 |
| 15:09 | <jmdyck> | I've got some comments on PR #3802 (but I haven't finished my analysis), so you might not want to merge just yet. |
| 15:12 | <jmdyck> | linus: That might just be an artifact of how MS Word worked. |
| 15:34 | <Michael Ficarra> | yep, I think we just matched MS Word when we converted it |
| 15:36 | <Michael Ficarra> | https://github.com/tc39/ecmarkup/blob/82954937fa8b14f6b3a9a7067e52d3fc738c6295/css/elements.css#L484-L520 |
| 15:38 | <linus> | fun |
| 15:38 | <linus> | are we fine with adding css to cover whatever the current max nesting level is or not worth it? |
| 15:41 | <Richard Gibson> | I'm fine with it. But even better would be never going so deep at all. |
| 15:43 | <Michael Ficarra> | what do you mean by adding CSS to cover? |
| 15:44 | <Michael Ficarra> | the CSS already does cover that, I linked it |
| 15:44 | <linus> | adding more css so it doesn't give up after 7+ |
| 15:45 | <linus> | or somehow letting the browser do the % 3 logic automatically |
| 15:47 | <Michael Ficarra> | I think I'd probably prefer not to change the step numbering scheme without a better reason |
| 15:48 | <Michael Ficarra> | it'd be unfortunate to break references to particular steps that people may have in code or documentation |
| 15:49 | <linus> | such references break all the time through editorial refactoring already |
| 15:50 | <Michael Ficarra> | yeah but I consider that "good reason" |
| 15:51 | <Michael Ficarra> | you just want it to loop through the different numbering schemes? |
| 15:51 | <linus> | yeah, that's what i assumed it does anyway, i never noticed it has a limit where it stops looping |
| 15:52 | <linus> | I'm writing myself a tool that needs to imitate nested spec rendering and got that part wrong |
| 15:53 | <linus> | i'm fine with hardcoding this constraint but wanted to at least bring it up beforehand :) |
| 16:00 | <Michael Ficarra> | I can see merits to both choices, so if you feel strongly, I wouldn't oppose it |
| 16:13 | <linus> | looks like current word and gdocs limit to 9 nesting levels but cycle until then - given our max level is 8 (GDI, EDI) i'd adjust the styles to support that but not more |
| 16:14 | <linus> | don't feel strongly about it tho |
| 16:14 | <Michael Ficarra> | would you change any step numbers that are nested less than 8 levels? |
| 16:15 | <Michael Ficarra> | or just the ones that are extremely deeply nested? |
| 16:15 | <linus> | level 7 turns from roman into decimal |
| 16:16 | <linus> | everything before that already renders "as expected" |
| 16:33 | <Michael Ficarra> | eh, yeah I guess it'd be an overall win |
| 17:34 | <ljharb> | is https://github.com/tc39/ecma262/pull/3875 ready for merging too? i'll go through the queue this afternoon |
| 18:34 | <Michael Ficarra> | for discussion at editor call: https://github.com/tc39/ecmarkup/pull/699 |