03:00 | <sideshowbarker> | Can someone confirm whether the change in https://github.com/mdn/content/pull/6255/files is correct per-spec? |
03:41 | <HE Shi-Jun> | sideshowbarker: IMO, it seems this PR just use slight different words but don't really have any real difference with the old sentences. |
04:12 | <HE Shi-Jun> | sideshowbarker: Oh, I think I missed the interesting thing it the PR, chrome/ff inconsistency :) It seems V8 don't keep order of a, b as the original order in the array when call compareFn(a, b) ... Spec seems say nothing about that. |
04:26 | <bakkot> | sideshowbarker: that's correct (as of https://github.com/tc39/ecma262/pull/1340) only for consistent comparison functions, which several of the samples discussed in that thread are not. The spec makes no guarantees about the sort order when the comparison function is not consistent |
04:28 | <bakkot> | That said it's definitely an improvement: for consistent comparison functions, compareFn(a, b) < 0 means "put a before b, regardless of where they were originally", not "leave them in their original order" |
06:13 | <sideshowbarker> | HE Shi-Jun: Thanks for commenting over there |
06:15 | <sideshowbarker> | bakkot: maybe I can push a commit to that branch with trims the change down to that |
06:15 | <sideshowbarker> | bakkot: in the meantime, a comment from over there would be welcome |
06:16 | <sideshowbarker> | I wish the spec itself has some more explicit language for developers on this |
06:17 | <sideshowbarker> | I am very happy with the spec sections that now have the non-normative green notes sections with explanatory text |
08:25 | <sideshowbarker> | bakkot: thanks for adding a comment on that MDN PR |
08:52 | <sideshowbarker> | does the change in https://github.com/mdn/content/pull/7027/files seem like a reasonable way to work around the issue described in https://github.com/mdn/content/issues/7026? |
08:53 | <sideshowbarker> | hmm, I guess this isn’t specifically a JavaScript issue – so will re-ask on #whatwg:matrix.org |
10:29 | <sideshowbarker> | https://github.com/mdn/content/issues/7034 is a good first issue for anybody interested in contributing to MDN |