| 17:33 | <ljharb> | https://twitter.com/threepointone/status/1739997407826649239 |
| 17:56 | <Jack Works> | fun bug. I think it's caused by optimization |
| 17:57 | <Jack Works> | (notice 2 errors have different classes) |
| 18:46 | <rkirsling> | yeah that's exclusive to V8 |
| 19:00 | <ljharb> | sounds like a great test262 test - filed https://github.com/tc39/test262/pull/3974 for that |
| 19:01 | <Chris de Almeida> | four space indents! outrageous! |
| 19:04 | <Chris de Almeida> | two shall be the number thou shalt count, and the number of the counting shall be two. three shalt thou not count, neither count thou one, excepting that thou then proceed to two. four is right out. |
| 19:08 | <ljharb> | lol |
| 19:08 | <ljharb> | i actually use tabs, the holy indentation character, and prefer 4-space-widths anyways, but in this case it's just what vscode did automatically |
| 19:09 | <ljharb> | (i mainly use tabs because i value semantics and accessibility, ofc, but i'm sure spaces folks have their reasons too) |
| 19:53 | <Chris de Almeida> | I originally preferred tabs in favor of just configuring the editor to specify the indent appearance (which you can do with spaces as well of course), but found that they too-often were unconfigurably rendered by external viewers (esp. code review tooling) and would look atrocious with absolutely massive indentation and therefore awful readability, so.. spaces it is! |
| 20:35 | <snek> | sounds like a great test262 test - filed https://github.com/tc39/test262/pull/3974 for that |
| 20:35 | <littledan> | what is an impl-contributed test? do you mean, in the staging directory? |
| 20:35 | <ljharb> | we should have any regressions that have actually occurred in the main suite. |
| 20:36 | <snek> | https://github.com/tc39/test262/tree/main/implementation-contributed |
| 20:36 | <snek> | ie v8 would fix this and add a regression test here |
| 20:36 | <littledan> | ah OK so staging was renamed? |
| 20:36 | <snek> | dunno |
| 20:36 | <ljharb> | i thought that dir was basically legacy, and staging was the new place for impls to contribute tests, and then they'd end up in the main suite |
| 20:36 | <ljharb> | iow, "impl-contributed" should go away, was my understanding |
| 20:37 | <snek> | i don't feel super strongly about this i just haven't seen many regression tests in the main suite |
| 20:37 | <littledan> | https://github.com/tc39/test262/tree/main/test/staging |
| 20:37 | <littledan> | yeah idk in the past I faced review pushback when trying to upload regression tests into test262, and I don't understand that whole thread of logic. I think we should make the tests as complete as possible, even if they are "duplicate" or unnecessary or something |
| 20:38 | <littledan> | if people are going to veto it out of the main test suite, at least put it someplace that it will be run in an automated way alongside other tests. Staging does this. |
| 20:39 | <littledan> | (staging is part of the main suite, that's part of the trick) |
| 20:39 | <snek> | sometimes regression tests are kinda weird because they fall into the category of denying extensions |
| 20:39 | <snek> | (this one doesn't, of course) |
| 20:39 | <littledan> | I don't care about that; I think the whole "extensions" thread of spec logic is incoherent |
| 20:39 | <littledan> | I'm glad we've moved more towards hooks |
| 20:44 | <snek> | yeah idk in the past I faced review pushback when trying to upload regression tests into test262, and I don't understand that whole thread of logic. I think we should make the tests as complete as possible, even if they are "duplicate" or unnecessary or something |
| 21:31 | <littledan> | why not both? |