| 13:50 | <dminor> | Possibly silly question, I'm working on source phase imports, and I have a number of test failures that are related to GetModuleSource throwing a SyntaxError (e.g. https://github.com/tc39/test262/blob/a6f387de323eb9ae56448bdb71c5d315df631ce4/src/dynamic-import/import-source-source-text-module.case#L8), but I'm unable to find GetModuleSource in either the source phase imports proposal spec text, or the main spec. Has this been renamed or moved? |
| 17:44 | <guybedford> | This is from an old version of the spec yes - we changed it to be a slot on the module record instead, and this change was brought to committee and made in https://github.com/tc39/proposal-source-phase-imports/pull/69 |
| 18:04 | <dminor> | Ok, yes, I do have that part implemented then, but I'm not throwing a SyntaxError. I take it that doing a source phase import on a JavaScript module should not set the [[ModuleSource]] slot for now, and then will end up throwing a SyntaxError because of it being empty? And that the '<module source>' bit in test262 should produce something with the [[ModuleSource]] slot set for testing? |
| 18:06 | <guybedford> |
Exactly
Can you clarify what you mean by this? |
| 18:14 | <dminor> | It's from this part, https://github.com/tc39/test262/blob/a6f387de323eb9ae56448bdb71c5d315df631ce4/INTERPRETING.md?plain=1#L166-L170 |
| 18:16 | <dminor> | I haven't implemented wasm modules yet, but I can fake something for testing. |
| 18:18 | <guybedford> | yeah that makes sense. formally it's supposed to also have AbstractmoduleSource in the prototype chain as well, but I'm not sure if that is currently tested in 262? |
| 18:18 | <guybedford> | I can do a correction PR if not, including the correction for the [[ModuleSource]] slot - thanks for pointing these out |
| 18:27 | <dminor> | Thanks for the clarifications. There are some tests for AbstractModuleSource itself (accessed through $262.AbstractModuleSource) but as far as I can tell, there's no tests verifying that the prototype is being set for <module source> modules correctly. |
| 18:27 | <guybedford> | ok I'll arrange a PR for those thanks for confirming |
| 18:28 | <dminor> | np! |