| 08:49 | <ptomato> | maintainers, how do you feel about merging iterator helpers tests? https://github.com/tc39/test262/pull/2818 |
| 08:49 | <ptomato> | I'm OK with it\ |
| 16:54 | <ljharb> | i'm ok with it too - i can rerun them against my polyfill first, later today |
| 17:22 | <shu> | ptomato: i would prefer it to be merged |
| 17:23 | <shu> | question for shu / other implementers: right now the TypedArray tests are almost all generic across all of the TypedArray types, including stuff like Atomics which are tested against every TA type. if I just add Float16Array to that list it's going to cause every one of those tests to fail. that seems undesirable for implementers. do you have thoughts? FAIL then we're not going to detect regressions in other TAs until F16Arrays land |
| 17:23 | <ptomato> | oh yeah I didn't mean there's any question about it, but I meant more like have folks done all the reviews they wanted |
| 17:23 | <shu> | but it sounds like you settled on a more granular approach anyways? |
| 17:23 | <shu> | ptomato: oh yes, V8 has |
| 17:25 | <shu> | bakkot: ideally we keep test granularity at file level and avoid having polymorphic tests; i know test262 already has capability to generate tests from sources |
| 17:27 | <bakkot> | yeah the conditional push will at least prevent failures |
| 17:27 | <bakkot> | in theory |
| 17:27 | <bakkot> | you can run https://github.com/tc39/test262/pull/3849 if you want to be sure |
| 17:27 | <bakkot> | (which does not include any Float16Array-specific tests yet) |
| 17:28 | <bakkot> | agreed that generating these from templates would be better but that's a lot of work |
| 17:28 | <bakkot> | and gpt is not yet quite good enough to do that for me |
| 17:28 | <bakkot> | maybe next year |
| 17:30 | <shu> | yeah conditional push sgtm |