09:58 | <jgraham> | Can someone point out to me what the errors are which are causing https://github.com/whatwg/html/pull/6921/checks?check_run_id=3205414516 to fail? |
10:23 | <sideshowbarker> | jgraham: https://github.com/whatwg/html/pull/6921/checks?check_run_id=3205414516#step:3:91
The |
10:39 | <jgraham> | sideshowbarker: Apparently not :( Would be nice if this would print out which lint rules are actually failing in each case |
10:39 | <jgraham> | (for clarity: I fixed the , , and still get the errors) |
12:10 | <sideshowbarker> | jgraham: I’ll check out the branch now, and try to see if I can debug it locally |
12:37 | <sideshowbarker> | jgraham: the one that’s failing is this:
|
12:37 | <sideshowbarker> | will look further |
12:38 | <sideshowbarker> | (And by the way I did not write this code.) |
12:39 | <jgraham> | Would be nice if it printed the actual re match along with the paragraph |
12:40 | <sideshowbarker> | indeed yeah it would be nice |
12:40 | <sideshowbarker> | this is nuts |
12:40 | <sideshowbarker> | anyway, I spotted a possible cause |
12:41 | <sideshowbarker> | “with with” |
12:41 | <sideshowbarker> | in lines 2-3 of the patch |
12:41 | <sideshowbarker> | will try fixing that now and re-testing |
12:44 | <sideshowbarker> | OK yeah, fixed three instances of that, and have one remaining other yet-unknown cause. Checking further… |
12:44 | <sideshowbarker> | ah, same — “with with” |
12:45 | <sideshowbarker> | yup, all fixed |
12:45 | <sideshowbarker> | will push a commit to your branch |
12:46 | <sideshowbarker> | …and done |
12:47 | <sideshowbarker> | sorry about that linter — we need to fix that |
13:03 | <jgraham> | sideshowbarker: Thanks! |
13:12 | <sideshowbarker> | cheers |