12:58 | <Domenic> | annevk: ping on re-review for https://github.com/whatwg/html/pull/6869 ? |
14:44 | <annevk> | Domenic: so to make sure I understand correctly, the remaining Window-object reuse question is about a subsequent navigation of this about:blank document, right? |
14:50 | <annevk> | Anyway, approved modulo that assumption and an optional nit |
15:11 | <Domenic> | annevk: yes, because you can't observe the Window before this initial pseudo-load, so you can't tell whether it was reused or not. |
15:20 | <jgraham> | TabAtkins: https://github.com/w3c/webdriver-bidi/pull/131 seems to have a bikeshed error that looks like a bug in the CSS SPec Preprocessor deployment (maybe I should file an issue as it suggests, but also I'm not sure how much attention is paid to issues on repos in tobie's personal GH). |
15:21 | <annevk> | Cool. Initially I was wondering if the Window would end up being replaced somewhere during the lifetime of the about:blank document (where Firefox would navigate to about:blank), but I realized that probably wasn't it. |
15:34 | <TabAtkins> | jgraham: looking |
15:34 | <TabAtkins> | Yup, bug on my end, apologies for that. I don't exercise that code path in my local test files... I should figure out how to. |
15:35 | <jgraham> | Thanks for investigating! |
15:39 | <TabAtkins> | Okay, GH is having issues atm, but as soon as it's up I'll push the fix. |
18:04 | <TabAtkins> | jgraham: GH is up and fix is pushed, lmk |
19:20 | <wanderview> | my PRs seem to be failing to build the preview with a bikeshed error... https://github.com/tobie/pr-preview/issues/93 |
19:20 | <wanderview> | FYI, in case its related |
19:24 | <TabAtkins> | It was the same; I forgot that the processor relies on the pypi version. Update published. |
19:37 | <wanderview> | thanks |
20:40 | <wanderview> | TabAtkins: hmm, still seem to be getting 500's from pr-preview |
21:14 | <TabAtkins> | wanderview: learn something new about Python every day. confirmed it's fixed now, just pushed up, lmk |