| 06:27 | <hsivonen> | but of course that again means changing the tree construction test format to include them, which I know Henri has objected to before |
| 10:52 | <hsivonen> | Oops. I've manually landed changesets that had corresponding PRs open. Can I associate a changeset as being a PR merge after the fact? |
| 11:00 | <hsivonen> | I can't see anything in gh pr docs that would let me do that. Seems like an obvious thing to want to do. :-( |
| 11:23 | <hsivonen> | sideshowbarker: I'm bad at GitHub. Sorry. |
| 12:18 | <sideshowbarker> | hsivonen: no worries |
| 12:19 | <sideshowbarker> | I can review the commits and close the PRs |
| 12:20 | <sideshowbarker> | in the GitHub UI there may be some way to retroactively associate merged commits with PRs — I’m not sure, because I’ve never tried it |
| 12:21 | <hsivonen> | It seems like a feature that should be a FAQ-level thing, but I didn't find it. It's possible that I'm also bad at searching. |
| 12:22 | <sideshowbarker> | well, the searchability and coverage of the Github docs leaves a lot to be desired |
| 12:55 | <freddy> | Oops. I've manually landed changesets that had corresponding PRs open. Can I associate a changeset as being a PR merge after the fact? |
| 12:59 | <sideshowbarker> | thinking about that, I considered that maybe I could rewrite the commit messages for the commits on the validator-nu branch only — not the main branch |
| 12:59 | <sideshowbarker> | I have rewritten the history on the validator-nu branch of the htmlparser repo many times — but never by changing the commit messages from upstream commits from the main branch |
| 13:00 | <sideshowbarker> | I think if I changed the commits messages on the validator branch, that’d break rebasing of the branch against the main branch |
| 13:01 | <sideshowbarker> | I guess we could just re-write them in the history on the main branch, but we have so far never rewritten history on the main branch |
| 13:34 | <annevk> | freddy: there's an association outside of that, called associatedPullRequests, but I cannot find a way to programmatically set it. The only way I know it gets populated is through the merge UI on github.com. (Though maybe if you merge a PR through gh pr it also gets set, haven't tried that.) |
| 14:00 | <hsivonen> | AFAICT, the association only happens through PR/Issue titles and commit messages. Maybe you can change a PR title to point to the issue, otherwise you might have to rewrite the commit message :< |