06:17 | <annevk> | Cool! As long as there's some WHATWG green and orangered in there I'm happy 😊 |
06:19 | <annevk> | smaug: generally for WHATWG specs it should all be linked from the README |
06:20 | <annevk> | smaug: if there's things missing there or https://github.com/whatwg/meta/blob/main/CONTRIBUTING.md (which should be linked from all our READMEs) that would be good to know; probably best to file an issue against whatwg/meta |
10:33 | <smaug> | annevk: I've been hoping to have some simple step-by-step instructions. If I start from the spec, I get to https://github.com/whatwg/html, which links to https://github.com/whatwg/html/blob/main/CONTRIBUTING.md which links to https://github.com/whatwg/meta/blob/main/CONTRIBUTING.md . then one goes back to previous page which says something about wattsi (but doesn't tell whether that should be installed, but kind of hints about it), and then there is a link to https://github.com/whatwg/html-build. oh, and I forgot a link to https://github.com/whatwg/meta/blob/main/COMMITTING.md was also mentioned somewhere |
10:34 | <smaug> | So the information is in various places and not in any clear order |
10:38 | <annevk> | smaug: that's fair; though it's also tricky to find the right balance there since the most basic thing is "create a branch", "edit a file", "commit", "create a PR" |
10:40 | <smaug> | Since I live mostly in mozilla-central, I've got used to so simple build + "pr creation" setup with ./mach and moz-phab 😉 |
10:40 | <annevk> | And generally build tools beyond make are optional, there's a service for all of them (or you can just create PRs and see if things work) |
10:41 | <annevk> | smaug: right yeah, git/GitHub knowledge is assumed at the moment... I'm using GitHub Desktop myself for some of the actions and it's quite nice if you don't mind a GUI |
10:43 | <smaug> | I wasn't thinking to include all the github instructions, although some common practices might not be a bad idea, if there are things which happen to fit into spec writing process particularly well |
10:48 | <annevk> | Perhaps a "Your first PR" list of steps that's linked prominently from each README? (With HTML perhaps having its own list of steps for reasons.) |
10:53 | <smaug> | Something like that would be great, at least for me, since all my spec prs are basically the first ones, given how rarely I do them. |
11:03 | <annevk> | smaug: I filed https://github.com/whatwg/meta/issues/232 as a start |
11:04 | <smaug> | thanks! |
14:22 | <Domenic> | Cool! As long as there's some WHATWG green and orangered in there I'm happy 😊 |
14:33 | <Andreu Botella (he/they)> | So apparently Chromium's UTF-16 decoder skips the replacement character for truncated sequences on fetches (that is, for page loads and XHR, but not for TextDecoder ) "for compatibility reasons" |
14:33 | <Andreu Botella (he/they)> | https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/wtf/text/text_codec_utf16.cc;l=73 |
14:33 | <Andreu Botella (he/they)> | annevk: hsivonen Is this a thing that was ever discussed? |
14:39 | <Domenic> | Seems bad. I suspect we might be able to fix it like we did the recent JSON/UTF-8 bug. |
15:16 | <annevk> | Andreu Botella (he/they): I'm pretty sure it's considered a bug (EOF behavior has been discussed a lot, including that browsers do it badly), might even be filed |
15:17 | <annevk> | Andreu Botella (he/they): unfortunately doing the easy "blame" thing on that file seems hard, suspect that comment was added a long time ago |
15:22 | <Andreu Botella (he/they)> | yeah, and the blame for this test suggests that whatever compatibility constraints (IE I assume) no longer apply, since lone surrogates at EOF used to decode as is and were later changed |
15:22 | <Andreu Botella (he/they)> | https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/encoding/char-decoding-truncated.html |
15:35 | <hsivonen> | annevk: hsivonen Is this a thing that was ever discussed? |
15:35 | <hsivonen> | Fixing in the sense of generating the U+FFFD. |