| 14:34 | <smaug> | sideshowbarker: Did https://github.com/whatwg/html/issues/2683 get some wpts? |
| 14:34 | <sideshowbarker> | smaug: yes, gimme a minute, I’ll fetch them |
| 14:36 | <smaug> | aha, https://github.com/web-platform-tests/wpt/pull/29405 |
| 14:36 | <smaug> | maybe |
| 14:37 | <sideshowbarker> | yeah — the actual tests can be run here: |
| 14:38 | <smaug> | sideshowbarker: so does the print-during-unload.html pass with the patch? |
| 14:38 | <smaug> | (gecko patch) |
| 14:38 | <sideshowbarker> | yes |
| 14:38 | <smaug> | ok, then an .ini file needs to be removed |
| 14:38 | <smaug> | commented in phabricator |
| 14:38 | <sideshowbarker> | OK, I can update the patch |
| 14:38 | <smaug> | thanks |
| 14:39 | <sideshowbarker> | did you already comment there about which exact .ini file? |
| 14:40 | <sideshowbarker> | ah you did, thanks |
| 14:43 | <smaug> | the setup is quite simple, the .ini files are under /meta when the tests are under /tests |
| 14:43 | <sideshowbarker> | OK |
| 14:45 | <sideshowbarker> | all right, updated the patch |
| 14:45 | <sideshowbarker> | there were actually three .ini files to remove |
| 14:45 | <smaug> | ah, other tests pass too, even better |
| 14:46 | <sideshowbarker> | yeah |
| 14:46 | <smaug> | sideshowbarker: do you have rights to land the patch? or should I? |
| 14:47 | <sideshowbarker> | I can’t land it myself — I only have Level 1 commit access — so it’d be great if you could land it |
| 14:48 | <smaug> | done. Hopefully there aren't any bizarre mochitests for this 🙂 But if there are, we can tweak those later. |
| 14:48 | <sideshowbarker> | yup |
| 14:49 | <sideshowbarker> | thanks much |