09:21 | <sideshowbarker> | smaug: https://phabricator.services.mozilla.com/D131050 is maybe now ready to be merged (can’t merge it myself because I lack the perms) |
15:54 | <smaug> | sideshowbarker: ok, will do |
15:55 | <smaug> | sideshowbarker: hmm, error |
16:40 | <sideshowbarker> | smaug: error? |
16:40 | <smaug> | sideshowbarker: those inis make android as passing and others with error |
16:40 | <smaug> | but it is Android which is failing, no? |
16:40 | <smaug> | (because the method isn't there) |
16:43 | <jgraham> | Yeah those ini files don't make much sense; a subtest can't get the status OK or ERROR , only a test file. |
16:45 | <jgraham> | I'd expect
and similar for the other files. |
16:46 | <sideshowbarker> | Ok, then I need to change those to cause the test to just not be run on Android, right? |
16:46 | <jgraham> | Yeah you could do that as well if we're never going to implement print() on Android. |
16:47 | <jgraham> | Which would be something like
|
16:47 | <smaug> | or just keep the FAIL for android |
16:48 | <smaug> | (and pass elsewhere) |
16:51 | <jgraham> | Oh yeah, I guess my first suggestion is wrong if the test catches the exception, in which case it will be FAIL |
16:51 | <jgraham> | For the subtest, not for the top-lvel test |
22:00 | <nmnbd> | Hello folks 👋 and sorry in advance if this is not the right channel to ask something like that :P I have a question on the following example: I would expect that the onClick function would run before the navigation happens to the |
22:07 | <Domenic> | nmnbd: it is not at all trivial to figure out how this is specced, so happy to help :). The good news is that it is specced. Hyperlinks causing navigation is done via https://html.spec.whatwg.org/#the-a-element:activation-behaviour . Now, what is activation behavior, and how is it positioned relative to click handlers? It is defined in https://dom.spec.whatwg.org/#eventtarget-activation-behavior . And the key reference is https://dom.spec.whatwg.org/#ref-for-eventtarget-activation-behavior%E2%91%A5 . I.e., when dispatching click events, we run activation behavior in step 11 of the dispatch algorithm. Whereas, we run event handlers (deep inside) step 5. So indeed event handlers are guaranteed to come before navigation. |
22:47 | <nmnbd> | I see.. does the function have to be quick enough and run between step 5 and 11, otherwise will be interrupted by the navigation? |