| 08:52 | <annevk> | I like Domenic's explanation in the issue. That AbortSignal can be thought of as an "ExceptionSignal". The way we did aborting it was a never a third completion state after all. |
| 11:52 | <Noam Rosenthal> | annevk / Domenic : ping re. my 3 pending timing-related PRs when you get a chance :) https://github.com/whatwg/fetch/pull/1311 |
| 12:15 | <Andreu Botella (he/they)> | So I was giving it a try at rewriting Deno's implementation of timers, and I noticed some non-timer WPT tests failing |
| 12:16 | <Andreu Botella (he/they)> | Turns out, according to the spec, calling clearInterval inside an interval's callback should not clear it – but every browser does |
| 12:16 | <Andreu Botella (he/they)> | The handle's entry in the map of active timers is set no matter what in the timer initialization steps for the next iteration of the interval |
| 12:38 | <annevk> | Can you elaborate? Doesn't the spec synchronously mutate the map of active timers? |
| 12:40 | <Andreu Botella (he/they)> | After the callback, if repeat is true, the timer initialization steps are run again, whether the handle is in the map of active timers or not |
| 12:40 | <Andreu Botella (he/they)> | And the timer initialization steps, in step 14, will add the handle to the map of active timers |
| 12:44 | <annevk> | Ah I see. It should probably do the same check as it does in step 1 of the task, after executing the callback. |
| 12:44 | <Andreu Botella (he/they)> | Indeed |
| 12:57 | <annevk> | Noam Rosenthal: 1311 still seems to have unaddressed comments from Yutaka |
| 12:59 | <annevk> | Noam Rosenthal: also, is the discussion with Yoav Weiss and npm1 resolved? Did anything change as a result? |
| 13:00 | <annevk> | Going to leave the others to Domenic. |
| 13:00 | <Noam Rosenthal> | I've addressed them by changing the scope of the PR for what's already implemented modulu a few open bugs. Anything missing from the discussion Yoav? |
| 13:04 | <annevk> | I see, excluding non-HTTP(S) and abort network errors. I guess that works. |
| 13:05 | <annevk> | Yutaka's comments still seem applicable though. |
| 14:18 | <Yoav Weiss> | There's an open question of who would implement this in Chromium, but that doesn't imply Chromium is not interested in implementing |
| 17:22 | <Noam Rosenthal> | Yoav Weiss: can you make this clearer in the PR discussion? It seems chaotic to read right now from the Chromium perspective |