00:39
<zcorpan>
Sigh... Leanpub have moved API publishing to their Pro plan. I guess I have to switch to something else
01:13
<zcorpan>
or it seems I can still use GitHub writing mode, but need to press a button to publish
13:15
<Noam Rosenthal>
Jake Archibald: hola! when you get a chance, https://github.com/whatwg/fetch/pull/1329 can still benefit from some of your review time
15:23
<wanderview>
sideshowbarker: I believe that URL issue in chrome is crbug.com/869291... since URLPattern constructor had to use a separate (but similar) parser, I chose to follow the spec there in the hopes chrome url parser will get fixed in the future
22:28
<sideshowbarker>

ah OK, thanks — I’m surprised I didn’t know about that issue before now.
And yeah about the parser difference, I had read the note at https://wicg.github.io/urlpattern/#ref-for-concept-basic-url-parser in the spec:

The URLPattern constructor string algorithm is very similar to the basic URL parser algorithm, but some differences prevent us from using that algorithm directly.

But then it seems there must be a bug in your pattern.test() implementation, right?
I mean for the following:

const pattern = new URLPattern({ hostname: '{*.}?example.com' });
console.log(pattern.test('custom-protocol://example.com/other/path?q=1'));
// false
22:29
<sideshowbarker>
per-spec, the value of that pattern.test('custom-protocol://example.com/other/path?q=1') should be true?
22:29
<wanderview>
the pattern.test(arg) runs the browsers url parser... which in chrome does not produce a hostname (incorrectly)
22:29
<wanderview>
thats a bug in the url parser, not pattern.test()
22:29
<sideshowbarker>
aha
22:30
<sideshowbarker>
got it — thanks
22:30
<sideshowbarker>
now I need to figure out how to word the comment for https://github.com/mdn/content/pull/13137/files#diff-a96bc8239765e58f018eadd82a682acbb766184024a6b80d68322e89051d8e7cR272