08:57 | <annevk> | Domenic: not sure I'm totally onboard yet, but it might be interesting to figure out how often stopImmediatePropagation() is used and whether we could make it controlled by yet another boolean controlled by the dispatcher |
16:32 | <smaug> | bkardell: oops, did I leave too early |
16:32 | <smaug> | I'll try to review the pr |
16:32 | <smaug> | ping me if I don't |
16:32 | <smaug> | (I was traveling last week) |
16:44 | <bkardell> | bkardell: oops, did I leave too early |
16:55 | <bkardell> | annevk: sorry about that - i think I fixed the things you mentioned last week. I expect that line wrapping bit is gonna be a general thing to fix in the other :dir PR too |
16:55 | <bkardell> | (in the silly 9088 one https://github.com/whatwg/html/pull/9088) |
17:14 | <annevk> | bkardell: it would be great if any nits are fixed ahead of general review as the nits tend to make reviews very noisy |
17:53 | <annevk> | Andreu Botella: thanks again for https://github.com/whatwg/url/pull/735#issuecomment-1441503315! I will try to find some time to write tests soon |
17:53 | <Andreu Botella> | sure! |
18:00 | <bkardell> | bkardell: it would be great if any nits are fixed ahead of general review as the nits tend to make reviews very noisy |
20:08 | <bkardell> | You mean on the dir one? |