WHATWG
2023-07-21
plaintext logs
prev next
source on github
09:51
<jgraham>

Is the build for fetch broken on main? Locally I'm seeing:

jgraham@goldfinch:~/develop/fetch$ git fetch origin 
jgraham@goldfinch:~/develop/fetch$ git checkout main 
Switched to branch 'main'
Your branch is up to date with 'origin/main'.
jgraham@goldfinch:~/develop/fetch$ make
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  374k    0   146  100  374k     18  49062  0:00:07  0:00:07 --:--:--    40

Error running preprocessor, returned code: 2.
FATAL ERROR: Spurious / in &lt;a>.
 ✘  Did not generate, due to fatal errors
make: *** [Makefile:5: remote] Error 22
09:53
<jgraham>
make local works fine, so maybe there's a difference between the remote version of bikeshed and the local one?
09:54
<jgraham>
(also I really do prefer specs that don't depend on make for unclear reasons)
09:58
<annevk>
Why are the reasons unclear?
09:59
<annevk>
This might be the Bikeshed parser changes TabAtkins made. I'm not sure if he tested those on just the tests or also live copies of the current specifications. I haven't really done any specification development recently.
12:01
<annevk>
jgraham: I suspect it's failing on main: https://github.com/whatwg/fetch/pull/1655#issuecomment-1642314570
16:15
<jgraham>
Because specs have trivial dependency graphs, so they don't need any of the features of a complex build system, meanwhile the build system itself becomes an additional requirement. Plus make itself is only well understood by relatively few people.
16:24
<annevk>
I mean, we could replace it with something else, but what else is as cross-platform and readily available?
17:48
<TabAtkins>
I tested on all the specs, but I still don't track build messages in the testsuite, that'll be fixed this quarter. So Fetch builds an identical output, it just has a different set of messages. (Apologies for that.)
17:48
<TabAtkins>
anyway lemme see what's up
17:54
<TabAtkins>
Ah, it's actually catching a legimately broken tag.
17:54
<TabAtkins>
<a for/>, meant to be <a for=/>
17:56
<TabAtkins>
https://github.com/whatwg/fetch/pull/1689
17:56
<TabAtkins>
annevk: ^^^