00:31 | <sideshowbarker> | a friend of mine is asking about how to make use of native context menus on the web, and told me that there was an old now removed thing in firefox which included the menuitem element. are yall aware of any current work or plans to make this kind of thing possible? |
00:33 | <jarhar> | was there any issues that implementors brought up? |
00:34 | <sideshowbarker> | At this point I don’t recall. Would need to do some archaeology. Anne or Domenic might remember more |
00:37 | <sideshowbarker> | |
00:38 | <sideshowbarker> | found https://github.com/whatwg/html/commit/e7e8c88e |
00:39 | <sideshowbarker> | …which links to https://bugs.chromium.org/p/chromium/issues/detail?id=87553&desc=2#c64 |
00:40 | <sideshowbarker> |
|
00:41 | <sideshowbarker> | …for which one way of reading it is, “because WebKit hasn’t implemented it, we don’t think it’s enough of a priority” |
00:46 | <jarhar> | thank you for finding this! |
00:46 | <sideshowbarker> | cheers |
06:39 | <annevk> | akaster: oh wow, file an issue? I guess we should just update the spec then. |
06:41 | <akaster> | Sure thing! I was wondering if maybe my interpretation of "HTML Element" was wrong given how they all agreed 😅 |
06:55 | <akaster> | I made issue 9766 for this |
07:08 | <annevk> | Thanks! (HTML element definitely means HTML namespace.) |
07:33 | <Noam Rosenthal> | The team working on HTTPS auto-upgrades would like to get https://github.com/whatwg/fetch/pull/1655 into Fetch. What's their next step toward merging it? |
08:16 | <sideshowbarker> | annevk: about the “document.open() does not change document's URL (active but not fully active document)” test case at https://github.com/web-platform-tests/wpt/blob/db6e5032915eb0dcb1d8b8b249488055378245fd/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.js#L28 : in light of https://github.com/whatwg/html/pull/4076 — and specifically the requirement “A Location object has an associated url, which is this Location object's relevant Document's URL , if this Location object's relevant Document is non-null, and about:blank otherwise” — shouldn’t that test be updated to change the assert there to assert_equals(childWin.location.href, " about:blank ") ? |
09:12 | <annevk> | sideshowbarker: I'm not sure that's accurate, relevant Document is childFrame.contentDocument, which is non-null, right? |
09:29 | <annevk> | Jeffrey Yasskin: Noam Rosenthal: I gave it another pass; things that could help in the future: ensure Build is passing, commit message is clear, checklist in OP is filled out, there's a PR somewhere for renaming tentative tests to non-tentative tests; if either of you wants to review it as well that'd be appreciated |
09:52 | <Noam Rosenthal> | Jeffrey Yasskin: Noam Rosenthal: I gave it another pass; things that could help in the future: ensure Build is passing, commit message is clear, checklist in OP is filled out, there's a PR somewhere for renaming tentative tests to non-tentative tests; if either of you wants to review it as well that'd be appreciated |
09:56 | <annevk> | Euh, XML doesn't define what to do with data:text/xml,<?xml%20version="1.0"%20encoding="a"?><b/> ? Five editions! |
10:01 | <annevk> | (Tracked in https://bugs.webkit.org/show_bug.cgi?id=18110 for now.) |
10:01 | <sideshowbarker> | sideshowbarker: I'm not sure that's accurate, relevant Document is childFrame.contentDocument, which is non-null, right? Yeah, seems so — and that’s also what I had thought, but WebKit is the only UA to have implemented that spec change, and WebKit returns Take a look at https://searchfox.org/wubkat/source/Source/WebCore/page/Location.cpp#53-54. That entire code assumes there’s a single |
10:13 | <annevk> | Does anyone know how you find out if indexing a spec got stuck? XHR still doesn't pick up terms we introduced in HTML two days ago. |
10:13 | <annevk> | TabAtkins maybe? |
10:14 | <annevk> | sideshowbarker: are you saying Frame is 1:1 with Document ? I'm not familiar with how this stuff is implemented in browsers unfortunately. |
10:45 | <sideshowbarker> | I don’t know — I need to trace through the rest of the code more. But code-wise, I see that Location code has access to a LocalDOMWindow window, along with access to that frame() Frame, and naïvely I wonder if it should be getting the document from that LocalDOMWindow object rather than from the Frame. Anyway, if I can’t get it figured out, I’ll raise a bugs.webkit.org bug. The failing test case is at https://wpt.fyi/results/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.html |
11:25 | <TabAtkins> | Huh, I see that I was mentioned but can't find the message with it |
11:30 | <TabAtkins> | Oh I skipped right past it, nm. I'll check in a bit, annevk: |
11:30 | <TabAtkins> | (it's 4am right now, my sleep is disordered due to COVID) |
12:06 | <annevk> | Sorry to hear that. I guess the number of people impacted by TPAC is still rising. 🙃 |
12:17 | <annevk> | (Although if you're in California again I wonder if it's not jetlag as that's my usual visiting-California-wake-up time.) |
12:25 | <TabAtkins> | I got home on Saturday night, my jetlag doesn't last that long. 😅 |
12:27 | <aja> | at least you're not still stuck at DFW |
12:31 | <TabAtkins> | Lord, yeah. Actually got home *faster* than planned, the Atlantic flight got in early and I got myself bumped to an earlier flight for my last leg. |
12:42 | <sideshowbarker> | annevk: If I make a change to the Location-handling code in WebKit (specifically, to the I just locally ran all 926 tests in the |
12:50 | <emilio> | annevk: sorry for the massive comment in the switch issue :/ |
12:51 | <emilio> | annevk: but I think it's important we get these details right to avoid the kind of mess we're in with some of the other form controls |
13:51 | <annevk> | sideshowbarker: that seems about right |
13:54 | <annevk> | emilio: that's very useful, thanks! |
13:59 | <annevk> | emilio: I'll do some more investigation. Might take a while. If zcorpan has some notes somewhere from when he investigated all this for Ideally I'd like to tackle this in stages, but there should be sufficient information for each stage and earlier design decisions shouldn't cause us to run into issues later on. |
14:01 | <zcorpan> | IIRC I didn't investigate checkboxes so much |
14:03 | <annevk> | zcorpan: it's not too late 😅 |
14:05 | <zcorpan> | annevk: it never is :) |
16:54 | <zcorpan> | annevk: implementer interest or opposition for webkit? https://github.com/whatwg/html/pull/9538 |
17:06 | <annevk> | zcorpan: support, made me remember to actually label https://github.com/WebKit/standards-positions/issues/86 properly |
17:34 | <sideshowbarker> | annevk: will see what Chris says about https://github.com/WebKit/WebKit/pull/18026. I don’t yet understand exactly that the Frame abstraction maps to in the spec — but whatever its purpose, it seems like the code can and should just be using the available Window instead. And the test results also seem to indicate that’s what should be happening. |
19:42 | <Jeffrey Yasskin> | Jeffrey Yasskin: Noam Rosenthal: I gave it another pass; things that could help in the future: ensure Build is passing, commit message is clear, checklist in OP is filled out, there's a PR somewhere for renaming tentative tests to non-tentative tests; if either of you wants to review it as well that'd be appreciated |