| 07:15 | <meacer> | meacer: happy to try review quickly if you also address the comments somewhat quickly |
| 07:55 | <annevk> | meacer: in that case you can probably put it directly in HTTP-network fetch? |
| 08:01 | <annevk> | meacer: because the early cache lookup in 25 is very specific and I don't think ends up applying here |
| 08:32 | <freddy> | Great to see such speedy reviews and patch feedback loops on HTTPS Upgrades. I'm curious about the answers to my questions about a) redirects and b) IP addresses in the hostname |
| 08:45 | <annevk> | So if we do this in HTTP-network fetch it would be way before redirects are handled. Not sure if that answers your question or not. |
| 08:46 | <annevk> | meacer: do we have any kind of cross-browser testing story for this feature? |
| 09:16 | <freddy> | The tests linked from the pull requests are just https://github.com/web-platform-tests/wpt/tree/master/https-upgrades/tentative. |
| 09:48 | <annevk> | I see, I'm not sure there is a lot more that can be tested as most everything else is handled by Mixed Content presumably |
| 10:27 | <freddy> | Redirects? :) |
| 17:27 | <meacer> | freddy: Sorry, I wasn't ignoring your comments, just wanted to ask the team about the IP addresses first :) We had a "non-unique hostnames" exception in the first draft (e.g. site.test etc) which presumably covered IP addresses. But it might be a good idea to spell out IP addresses explicitly. |
| 17:28 | <meacer> | As for the tests, I have an additional SW related WPT that I'll land for this. |
| 17:33 | <meacer> | Could probably write one for redirects as well |
| 19:35 | <freddy> | Would be great. If you don't, we will ;) |