| 18:24 | <annevk> | Pfff. That <select> thread with Open UI folks is so weird. |
| 21:54 | <smaug> | keithamus: I can't comment on lines which haven't been changed when reviewing a pr? |
| 21:54 | <smaug> | keithamus: I'm looking at the open attribute removal |
| 21:56 | <smaug> | keithamus: don't the focusing steps possibly trigger events synchronously ? Maybe I'm missing something |
| 21:57 | <smaug> | jarhar: ^ |
| 22:00 | <keithamus> | Which PR is this in question? |
| 22:03 | <jarhar> | oh yeah i thought about that too |
| 22:03 | <jarhar> | when closing the dialog we focus another element synchronously |
| 22:04 | <jarhar> | and it might be a bad idea to fire an event while removing an attribute |
| 22:04 | <jarhar> | not sure whats best |
| 22:04 | <smaug> | keithamus: https://github.com/whatwg/html/pull/10124 |
| 22:04 | <jarhar> | we could skip that step for attribute removal if needed |
| 22:07 | <keithamus> | smaug: oh I see what you mean about github not letting you add a comment. We've got that feature in the backlog 🫠|
| 22:07 | <smaug> | good good 🙂 |
| 22:11 | <smaug> | But about the behavior, I think it would be nice to have similar behavior as what calling close has. Are there other cases when removing an attribute triggers events this way? (not talking about mutation events) |
| 22:12 | <smaug> | Looks like DOM spec wouldn't like sync events |
| 22:22 | <keithamus> | <details>? Removing the attribute closes but I don't recall if it triggers events |
| 22:25 | <keithamus> | https://searchfox.org/mozilla-central/source/dom/html/HTMLDetailsElement.cpp#45-67 looks like it dispatches the toggle event if you remove the open attribute, but that's done in a task. |
| 22:25 | <smaug> | right, also per spec |
| 22:27 | <keithamus> | I'd love to chat more about this. I'm trying to understand the constraints and get a way for all groups to progress. It feels like something is getting lost in the comments. |
| 22:28 | <smaug> | (oh, details has some rather unusual mutation events flag usage in the spec) |
| 22:31 | <smaug> | hmm, doesn't popover removal have a bug |