08:13 | <sideshowbarker> | zcorpan: No WPT tests for composition events with textInput ? |
14:52 | <zcorpan> | sideshowbarker: No, I think it can't be automated |
14:52 | <zcorpan> | We could have manual tests though |
14:53 | <sideshowbarker> | OK |
15:03 | <sideshowbarker> | zcorpan: In the WebKit tree there are actually some automated tests that cover it, using https://github.com/WebKit/WebKit/blob/main/Tools/WebKitTestRunner/InjectedBundle/TextInputController.cpp. Maybe other engines have some similar engine-specific testing tool for it. I had imagined that there might be some WebDriver-based way to do it. But maybe the nature of it such that there can’t be, I dunno |
15:06 | <sideshowbarker> | I can say that I’m glad those test existed, because my patch had actually regressed them — but without having CI running those tests, and seeing the failures, I wouldn’t have known otherwise |
15:10 | <sideshowbarker> | hmm, I do see now that the WebDriver spec at least defines a way to dispatch composition events — https://w3c.github.io/webdriver/#dfn-dispatch-a-composition-event (which requires the remote end to “perform implementation-specific action dispatch steps”) |
22:01 | <Di Zhang> | Hi WHATWG reviewers, I have this spec open and it hasn't received new comments in two weeks. I would appreciate getting another look. Thanks! https://github.com/whatwg/html/pull/10096 |