00:11 | <jarhar> | github added css to disable auto-expanding details |
00:11 | <jarhar> |
|
00:12 | <jarhar> | it works on some details element in github where there is no element in between the details and the text child, but not this one since there is a <p> in between the details and the "web service" text node |
00:13 | <sideshowbarker> | I see |
00:14 | <sideshowbarker> | Do you know why they’re intentionally disabling it? |
00:14 | <jarhar> | nope |
00:14 | <jarhar> | keithamus: any ideas? |
02:29 | <sideshowbarker> | I guess it’s due to https://github.com/primer/css/commit/8145e90a694820dd7d92a32161cb13e2b67a4d06#diff-3f525a94a06ff75c679cc6c537ff60dfe8c69e13af9fb029bc31a12399e3659e |
02:29 | <sideshowbarker> | “muan committed on Oct 16, 2017” |
02:30 | <sideshowbarker> | So maybe we could ask muan if/when she’s around |
02:33 | <sideshowbarker> | But from that it seems like it was never specifically intended to prevent auto-expand, but instead was added ~6 years ago as just part of a normal reset, in the context of https://github.com/primer/css/pull/346 and https://github.com/primer/css/pull/371 |
08:08 | <annevk> | Panos Astithas: I was planning on attending this morning and Marcos was too. Not sure if that would have tipped the RSVP balance however. |
08:09 | <sideshowbarker> | annevk: So there‘s no call? The calendar invite didn’t have a link to call details anyway |
08:15 | <annevk> | sideshowbarker: It was canceled per a calendar email I saw this morning. |
08:15 | <sideshowbarker> | aha |
09:34 | <keithamus> | We can probably remove those style rules now as <details> is well supported |
09:35 | <sideshowbarker> | Hi keithamus Yeah, that would be great |
09:35 | <sideshowbarker> | Should I raise an issue for it? |
09:36 | <keithamus> | That would be great! |
09:57 | <annevk> | Panos Astithas: I see you also mentioned this in https://github.com/whatwg/html/issues/10205. All good I think and sorry for not RSVP'ing sooner. |
11:19 | <sideshowbarker> | https://github.com/primer/css/issues/2592 |
17:06 | <annevk> | sideshowbarker Florian Scholz: can either of you help with this MDN question? Thanks! https://github.com/w3c/webappsec/pull/639#issuecomment-2013037309 |
19:56 | <Panos Astithas> | Yeah, sorry if this was a surprise, I tried my best to communicate early and often. The low attendance was secondary really, the main cause for canceling was the lack of agenda items. |
20:25 | <Eric Portis (he/him)> | TabAtkins Florian Rivoal : Miriam answered my question about whether contain-intrinsic-size should affect natural dimensions, above (it shouldn't). But now I have another question (take a look if you get a chance): https://github.com/w3c/csswg-drafts/issues/10116 |
22:18 | <sideshowbarker> | annevk: FYI https://github.com/mdn/content/pull/32781 — and in particular this part:
I suggested they file an XHR spec issue — but it’d also be great if you could do a (post-commit) review of https://github.com/mdn/content/pull/32781/files, and if there’s anything that’s wrong spec-wise, or worth clarifying further, we could do a follow-up PR |
22:23 | <sideshowbarker> |
|