02:33 | <sideshowbarker> | About https://github.com/mdn/content/pull/34087/files, That is, specifically this part:
|
02:33 | <sideshowbarker> | See also the related issue at https://github.com/mdn/content/issues/7859 |
02:46 | <sideshowbarker> | As far as I can see from looking just now, none of the loading steps in https://html.spec.whatwg.org/multipage/document-lifecycle.html#document-lifecycle actually reference handling for meta http-equiv="refresh" (instead, only handling for the Refresh header) — and https://html.spec.whatwg.org/multipage/semantics.html#attr-meta-http-equiv-refresh doesn’t state when in the loading process the “shared declarative refresh steps” must be run in the meta http-equiv="refresh" case. |
02:51 | <sideshowbarker> | I guess https://html.spec.whatwg.org/multipage/document-lifecycle.html#refresh could be possibly be sort of intentionally misread to state that
|
05:15 | <sideshowbarker> | OK, it’s since been pointed out to me that the relevant requirements are in fact already in the spec, in the definition of “a refresh is said to have come due” in step 13 of https://html.spec.whatwg.org/multipage/semantics.html#attr-meta-http-equiv-refresh
|
07:37 | <bkardell> | annevk: https://github.com/whatwg/html/issues/10407#issuecomment-2164768308 i feel like i did answer the actual question you asked about what happened to it, which is all i was trying to add.. 😋 |
07:38 | <bkardell> | I guess your question that remains is like "has the wg reached out to/coordinated with/considered them?" Is that right? |
08:28 | <sideshowbarker> | keithamus: About details auto-expand in GH issues, it still doesn’t seem to be working in Chrome — and my patch at https://github.com/primer/css/pull/2624 not been merged yet |
08:34 | <smaug> | krosylight: I think that star change is actually a bit different, since it is highlighted because the page gets bookmarked. So the process there is rather indirect |
08:46 | <krosylight> | krosylight: I think that star change is actually a bit different, since it is highlighted because the page gets bookmarked. So the process there is rather indirect |
08:48 | <smaug> | the page is star'ed immediately, I believe. The star stays highlighted even if you just hide the popup by clicking elsewhere |
08:49 | <krosylight> | the page is star'ed immediately, I believe. The star stays highlighted even if you just hide the popup by clicking elsewhere |
08:49 | <annevk> | bkardell: well that issue already pointed to that explainer so I'm not really sure how that was adding anything new |
08:50 | <krosylight> | smaug: you can see the difference by opening Manage Bookmarks popup and do the star thing |
08:51 | <krosylight> | New entry doesn't show up until you either dismiss the popup or click the save button |
08:52 | <smaug> | I guess that is when it is decided where the bookmark is stored |
08:53 | <krosylight> | Clicking the star immediately saves it into a temporary folder you mean? perhaps yeah |
08:54 | <krosylight> | All other popup-opening buttons get background highlight too (including the hamburger button), but I guess that's nothing to do with commands |
08:54 | <krosylight> | (or does it?) |
09:22 | <bkardell> | oh it did? weird, sorry - I missed it somehow |
14:36 | <annevk> | krosylight: bakkot: FWIW, I fixed some of the Float16Array test issues already |
15:11 | <bakkot> | thanks |
15:11 | <bakkot> | yeah I wasn't totally sure how to handle those |
15:11 | <bakkot> | the tests are not written in a way which makes them easy to split |
15:12 | <bakkot> | test262 does things in a slightly different way, where there is a central list of all the TA types, and in that case I could just conditionally add it to that list based on whether it's present |
15:13 | <bakkot> | but the WPT tests aren't really set up for that |
15:13 | <bakkot> | still, maybe the best option? duplicating every test seems less desirable |
15:16 | <annevk> | bakkot: I think there's a couple that have some duplication for the 64 case |
15:17 | <annevk> | bakkot: and some have the infrastructure that it's just a local failure by making the construction local to the test |
16:49 | <annevk> | Luke Warlow: I prolly can't look at Trusted Types PRs again until somewhere next week. Maybe zcorpan or Dominic Farolino can help out with some review on the DOM stuff meanwhile? I think your suggestion of an optional boolean is reasonable, if one path indeed has to be vetted and the other does not. (Not enough time at the moment to deeply investigate.) |
16:50 | <annevk> | Luke Warlow: and at worst I might not have time until July. Depends a bit on some unknowns. |
16:51 | <Luke Warlow> | Yeah no worries I'm OOO till at least Tuesday. It would be good to get other eyes on it too. I'm slightly blind to it given the iteration (apologies for the churn). Any other eyes over it would be great! |
16:54 | <annevk> | zcorpan: Dominic Farolino: for clarity, https://github.com/whatwg/dom/pull/1268 is the PR in question |
17:03 | <keithamus> | Thanks I’ll look into this as I can. It might be a week or two though. |
18:30 | <Dominic Farolino> | If you can formally request my review that'd be a great way to get it in my inbox |
18:30 | <Dominic Farolino> | Also tough for me to get to it before next Tuesday but I can try, or at the very least review it after. |
19:30 | <Luke Warlow> | As I say I'm OOO till Tuesday so no rush. I've added you as a reviewer. |