02:19 | <Domenic> | I would appreciate if someone would double-check my reading of the rules for choosing a navigable in https://github.com/whatwg/html/issues/11291 . It is surprising that this basic thing was missed for some time. |
02:56 | <akaster> | in firefox on linux both the links and the buttons all open new tabs |
02:57 | <akaster> | ah that's what the issue says |
03:01 | <sideshowbarker> | I kind of vaguely remember something about the “non-empty target names, other than _top, _self, and _parent, are treated like _blank in terms of deciding whether to open a new browsing context” text cited from that MDN page |
03:07 | <sideshowbarker> | after checking now, I can see it’s been in there for more than 4 years — ever since the wiki days https://github.com/mdn/content/blame/7a4949c39200965c35633b89ea0d7b5016a381e6/files/en-us/web/api/window/open/index.html |
03:08 | <sideshowbarker> | So… don’t know who might have added it to MDN originally, or when — but I guess they may just have discovered it from testing |
03:11 | <sideshowbarker> | For MDN, we still regularly get PRs that are cases of contributors saying, “I can’t find where any spec says this is what’s supposed to happen, but some testing shows that this is what browsers are doing” for some particular thing |
05:07 | <annevk> | Domenic: I suspect we even test that, but forgot about it when we did the recent tightening of conditions there? |
05:07 | <Domenic> | Hmm yeah, maybe I am just fooled by how clear the spec looks now |
05:14 | <Domenic> | https://github.com/web-platform-tests/wpt/blob/master/html/browsers/windows/auxiliary-browsing-contexts/named-lookup-scoped-to-browsing-context-group.html is kind of a test but not comprehensive. |
05:18 | <annevk> | jarhar: is there now a plan for landing all of the PRs? Is the parser change solid? (I think the nested button needs a bit more work still.) |
05:21 | <annevk> | jarhar: is https://github.com/whatwg/html/pull/10548 up-to-date? It didn't have a working PR Preview until I fiddled with it just now... When I look at https://whatpr.org/html/10548/2e87c0f...e556826/dom.html#select-element-inner-content-elements the option element inner content elements appears inconsistent. It doesn't have the nested list. |
05:22 | <annevk> | jarhar: if it indeed all fits in a single PR and we get working PR Preview that might be the best? Then we can all look through the generated diffs, address the final nits, and call it a day. |
17:07 | <jarhar> | could you elaborate on what should change about the nested button? are you talking about putting <button> inside <select>? |
17:10 | <jarhar> | i just pushed an update to the "complete" pr, it is up to date now |
17:11 | <jarhar> | ok yeah i could make two lists, one for included content and one for excluded content. does that sound good? |
17:17 | <jarhar> | i pushed a change to do this to the content model pr and updated the "complete" pr to include it too |