| 08:12 | <annevk> | zcorpan: when reviewing sideshowbarker's WebKit patch for ancestorOrigins I noticed the tests didn't seem to include identity asserts. I think we should add those as they are an important part of the API contract. |
| 08:13 | <sideshowbarker> | I have some added locally |
| 08:13 | <sideshowbarker> | Just waiting for a re-build to finish so I can confirm the code actually does what I think it should be doing |
| 08:14 | <sideshowbarker> | I wish we didn’t need that identity requirement. Things would be much easier if we didn’t 😄 |
| 08:14 | <sideshowbarker> | …as far as implementing at least |
| 08:22 | <annevk> | I mean if we only had to care about ourselves we'd prolly shut this thing down. 😛 |
| 08:23 | <zcorpan> | annevk: thanks. https://github.com/web-platform-tests/wpt/pull/56635 tests identity |
| 08:24 | <annevk> | Oh great, that looks exactly like what I was looking for. |
| 08:26 | <sideshowbarker> | yeah, should have known Simon already had it covered. I’ll throw out the test change I had hacked up, and just import that. |
| 10:24 | <zcorpan> | annevk: is this a good enough example (or 2 examples) to demonstrate that masking the top-level A doesn't happen in the first case? |
| 11:40 | <zcorpan> | annevk: I've addressed your comments now |
| 13:18 | <annevk> | zcorpan: really nice, thanks for completing that! |