| 03:34 | <jmdyck> | In https://html.spec.whatwg.org/#common-input-element-events, 3rd para, toward the end, it might be
or
|
| 03:36 | <jmdyck> | I'm pretty sure it's the latter, but it seems like that could be clearer. |
| 03:44 | <jmdyck> | In prose, you could distinguish the two by inserting a "both", e.g.
or
but it might be clearer to use an |
| 03:45 | <jmdyck> | Could the whole para be more list-ified? |
| 04:15 | <jmdyck> | It's one enormous sentence. |
| 06:42 | <annevk> | Yeah I think that would be a good change. |
| 11:19 | <emilio> | annevk: FWIW I just left a question in https://github.com/web-platform-tests/wpt/pull/57959#issuecomment-4223338679 (just saw the failure during triage). I'm not sure that expectation is justified? It doesn't match any other pseudo-element |
| 12:12 | <annevk> | emilio: yeah that does seem wrong. I can take a look later today but feel free to overwrite if you have something going already. |
| 12:12 | <annevk> | (Perhaps that test should be collapsed into the other pseudo-element tests.) |
| 12:18 | <emilio> | annevk: I think having the test separately is fine, either way tho... https://phabricator.services.mozilla.com/D293487 if you want to stamp :) |
| 12:19 | <emilio> | (cc keithamus ^) |
| 12:20 | <annevk> | emilio: hmm but what should happen when there's nothing in the style sheet? |
| 12:22 | <annevk> | Because now it's testing something slightly different as far as I can tell. |
| 12:36 | <emilio> | annevk: I mean, same thing? Style is resolved, just no rules applied, so default style inheriting from parent |
| 12:37 | <emilio> | annevk: but happy to test that as well i guess by adding another div |
| 12:40 | <annevk> | emilio: WebKit will pass with your change, pretty sure |
| 12:41 | <annevk> | So you'll be hiding the bug. |
| 12:43 | <annevk> | We pass existing ::file-selector-button tests around this for instance despite those using pretty much the same code path. Except the tests for that have an existing style rule. |
| 12:46 | <emilio> | annevk: ok, that's rather bizarre... Added a test for that |
| 14:24 | <annevk> | emilio: if you're curious: https://github.com/WebKit/WebKit/pull/62444 |
| 14:32 | <emilio> | annevk: sweet! |
| 20:01 | <Usama Nadeem> | hello there someone could tell me do It take more time? Im asking about the PR! and if theres some issue please do let me know! |