| 04:25 | <0x4261756d> | Hi, I've noticed that after the recent HTML spec changes regarding ProcessingInstructions there are some inconsistencies regarding the tree construction tests (previously at html5lib-tests/tree_construction, now at wpt/html/syntax/parsing/resources) and html5lib's tokenizer tests.
|
| 05:20 | <annevk> | TabAtkins Luke Warlow: landing https://github.com/speced/bikeshed-boilerplate/pull/200 broke every spec |
| 05:21 | <annevk> | I guess it's easy to resolve. |
| 05:25 | <annevk> | Hmm no something is still wrong after removing the TWITTER MACRO. |
| 05:27 | <annevk> | Could it be that not enough file hashes have been recomputed? https://github.com/speced/bikeshed-boilerplate/commit/4ff239a9589784ac1178711a5813351356a954dc |
| 08:26 | <annevk> | Luke Warlow: AI suggests there's a syntax error in your fix. The trailing comma. I guess I'll try to fix it. |
| 08:38 | <annevk> | TabAtkins: I had AI also create https://github.com/speced/bikeshed-boilerplate/pull/204 to prevent this from happening again. |
| 08:45 | <annevk> | Ah right, still have to wait for speced/bikeshed-data to actually pull in my fix. Sigh. |
| 08:49 | <Noam Rosenthal> | Thanks, I'll take a look at this. I introduced these tests but I have less track record with html5lib tests so I could have overlooked some inconsistencies |
| 11:08 | <Luke Warlow> | Luke Warlow: AI suggests there's a syntax error in your fix. The trailing comma. I guess I'll try to fix it. |
| 11:11 | <annevk> | I landed my fix already and whatwg/url is green again. |
| 20:49 | <TabAtkins> | JSON not allowing trailing commas in the syntax was such a fucking mistake |
| 20:49 | <TabAtkins> | just constant errors of this exact type, and diffs are so often a line larger than they should be because of adding or removing a comma to conform |
| 20:49 | <TabAtkins> | anyway, thanks for the new lint Anne |
| 20:50 | <TabAtkins> | (and spotting the path I'd missed in the other lint) |