04:25
<0x4261756d>

Hi, I've noticed that after the recent HTML spec changes regarding ProcessingInstructions there are some inconsistencies regarding the tree construction tests (previously at html5lib-tests/tree_construction, now at wpt/html/syntax/parsing/resources) and html5lib's tokenizer tests.

  • The tokenizer-subtests "Simili processing instruction" and "A bogus comment stops at >, even if preceded by two dashes" in test2.test, as well as all the tests for the format "<?" followed by a single alpha-char in test3.test no longer have the correct expectation (they expect a (bogus) comment but it should be a processing instruction now)
  • All tree construction tests in processing_instructions.dat are missing an "#errors"-section, the explicitly README requires that section ("Then there must be a line that says "#errors"."). It might be a better solution to update the README instead of the tests but one or the other should be updated.
  • Some tests in processing_instructions.dat escape special characters in #data (e.g. "\t" instead of the tab character). All other tree construction tests use the raw characters and again according to the README there should be no (un-)escaping happening ("All subsequent lines until a line that says "#errors" are the test data and must be passed to the system being tested unchanged, except with the final newline (on the last line) removed."). (Un-)escaping the input might be an improvement over the current behaviour (e.g. the input becomes more readable) but the current state is inconsistent.
05:20
<annevk>
TabAtkins Luke Warlow: landing https://github.com/speced/bikeshed-boilerplate/pull/200 broke every spec
05:21
<annevk>
I guess it's easy to resolve.
05:25
<annevk>
Hmm no something is still wrong after removing the TWITTER MACRO.
05:27
<annevk>
Could it be that not enough file hashes have been recomputed? https://github.com/speced/bikeshed-boilerplate/commit/4ff239a9589784ac1178711a5813351356a954dc
08:26
<annevk>
Luke Warlow: AI suggests there's a syntax error in your fix. The trailing comma. I guess I'll try to fix it.
08:38
<annevk>
TabAtkins: I had AI also create https://github.com/speced/bikeshed-boilerplate/pull/204 to prevent this from happening again.
08:45
<annevk>
Ah right, still have to wait for speced/bikeshed-data to actually pull in my fix. Sigh.
08:49
<Noam Rosenthal>
Thanks, I'll take a look at this. I introduced these tests but I have less track record with html5lib tests so I could have overlooked some inconsistencies
11:08
<Luke Warlow>
Luke Warlow: AI suggests there's a syntax error in your fix. The trailing comma. I guess I'll try to fix it.
Apologies! I tried testing it locally but perhaps the command I ran didn't do what I expected. I'm happy to review any fixed.
11:11
<annevk>
I landed my fix already and whatwg/url is green again.
20:49
<TabAtkins>
JSON not allowing trailing commas in the syntax was such a fucking mistake
20:49
<TabAtkins>
just constant errors of this exact type, and diffs are so often a line larger than they should be because of adding or removing a comma to conform
20:49
<TabAtkins>
anyway, thanks for the new lint Anne
20:50
<TabAtkins>
(and spotting the path I'd missed in the other lint)