| 20:26 | <rkirsling> | huh. seems like JSC is the only engine that throws on legacy decimal literals `\8` (template regardless of strictness) and 'use strict'; '\8'; (strict non-template) |
| 20:26 | <rkirsling> | but it seems like this should be correct |
| 20:43 | <rkirsling> | time to write some tests, I guess |
| 20:49 | <avp> | rkirsling: i've been trying to understand this as well today - were multiple bug reports filed? https://github.com/facebook/hermes/issues/267 |
| 20:50 | <rkirsling> | avp: yeah looks like it: https://bugs.webkit.org/show_bug.cgi?id=212887 |
| 20:51 | <rkirsling> | it's weird to have a case where engines are mostly converging on a non-conformant solution but that appears to be the case, due to lack of tests |
| 20:53 | <avp> | rkirsling: yeah i was second guessing my reading of the spec due to multiple other engines' behavior, but it's good to see JSC agrees |
| 20:54 | <Bakkot> | I could swear this was tested |
| 20:55 | <rkirsling> | I'm honestly shocked |
| 20:58 | <Bakkot> | lol, looks like I added `\08` but didn't cover `\8` |
| 20:58 | <Bakkot> | https://github.com/tc39/test262/pull/1063 |
| 20:58 | <rkirsling> | "noctal" haha |
| 21:00 | <Bakkot> | and there's https://github.com/tc39/test262/blob/master/test/language/literals/regexp/u-invalid-oob-decimal-escape.js for regexps |
| 21:03 | <Bakkot> | v8 actually tests that \8 and \9 are legal in templates: https://source.chromium.org/chromium/chromium/src/+/master:v8/test/mjsunit/es6/templates.js;l=509-512?q=templates.js&ss=chromium%2Fchromium%2Fsrc&originalUrl=https:%2F%2Fcs.chromium.org%2F |
| 21:03 | <rkirsling> | filed https://github.com/tc39/test262/issues/2653 |
| 21:04 | <rkirsling> | ehh, it's not unusual to have lingering tests for current but no-longer-conformant behavior |
| 21:06 | <Bakkot> | I don't think that was ever conformant |
| 21:11 | <rkirsling> | er yeah that part is odd |
| 21:49 | <rkirsling> | and PR https://github.com/tc39/test262/pull/2654 |
| 21:53 | <rkirsling> | heh test262 circle CI sends emails now? |
| 22:05 | <Bakkot> | aww, I can't see the circleCI results without authing with github, which grants read-and-write access to all my repos |
| 22:05 | <Bakkot> | (which I am not going to do) |
| 22:06 | <rkirsling> | I did it the first time without thinking much of it but I was required to re-auth just now which is super annoying |